Repository navigation
Keep typed delivery records through the UI model - #2934
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 93353dd, every finding: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep decoded delivery rows as UnresolvedInput and HistoricalInput through the UI model. InputDelivery.from_wire no longer re-encodes them into dictionaries. UnresolvedInput owns record_text(); HistoricalInput adds only the cleared-notice suffix through its override.
Must land together with OpenHCSDev/toad#1170 (Toad head 132b8c6eb64c2f38a687e9d5d23813dc87ad2558).
Before: DeliveryOverview declared the record fields, InputDelivery converted them back to dicts, and Toad restated the wire keys and formatting. After: the existing record classes own the display text, and the consumer joins row.record_text(). The external wire names and FieldCodec implementation are unchanged.
Migrated tests/test_thread_presentation.py's dictionary-built row. Updated tests/test_boundary_decoding.py's existing assertions to expect typed records rather than encoded dictionaries; malformed-record rejection assertions remain.
Interpreter comparison against Toad main's original _records function: current sequence row 65 bytes, direct input row 71 bytes, uncleared historical row 55 bytes, cleared direct historical row 96 bytes. Every before/after UTF-8 value is identical; joined output is identical at 293 bytes. The actual from_wire result contains UnresolvedInput current rows and HistoricalInput historical rows.
No pytest or test functions run. Changed modules parse; git diff --check passes. input_origin.py is untouched.
Assumed: delivery detail text is intentionally unchanged; the two repos are advanced together. Bases: Core fc69af9 and Toad 96ab9fee4.