Repository navigation
Conversation
This was referenced Oct 16, 2026
Author
|
Closing: 1468 commits behind main with conflicts. The same deletion of GoalBar's CSS-selector lookups is ordered fresh on current main as P705 (core-commander-2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
GoalBar's widgets already have a clear lifetime. Repeatedly reconstructing their identity from CSS selectors was pointless, especially the conversation-wide resize/mouse lookups.
Core goals, actions, source fences, polling behavior, CSS, pulse painting and layout calculations are unchanged. No widget stores a second goal/queue snapshot. No cache, timer, selector wrapper, alias or alternate codec.
Source evidence
Stacked on #697 /c028764d; head8aa06062. Four production files, +115/−74.
Existing NRA Package parser: Toad281 + Core328 + Textual254 = 863 parsed, zero omissions. Before/after declarations, writes, checks, imports, inheritance and consumers:
.artifacts/selector-queries/goal-{before,after}.txt; query inventorygoal-query-sites{,-after}.txt. Widget and slash-command GoalControl are distinct qualified types; only the widget constructor changes.The Textual source
message_pump.py:912-961dispatches handlers through the C3 MRO, so the binding's goal mouse handler still follows Conversation's offset handler;stop()is notprevent_default(). AST does not prove this execution. Source has no GoalBar recompose caller; native widget ownership lasts with the containing view.Receiving ratchet againstc028764d exit0, zero positive deltas (
goal-ratchet.json). No automated Toad tests or fixtures. Source checks do not prove application behavior or frame time.Shared-file check: #689 changes HistoryInteraction only; this changes CollapseInteraction only. #670's GoalControl activation hunk is already present here and preserved; no competing Forms work. #682 is deferred owned work. Paint/layout algorithms and CSS were preserved; theme owner was notified before editing.
Required live check
Pending review/normal installation by Codex, not a source-overlay app. Use the accepted XvfbDisplay.input helper read-only by path, real st / isolated display and saved sessions: goal push/return, collapse/expand, border resize, narrow controls, readonly History/editor cancel, queue separator changes, and channel/DM opening. Do not mutate original goals or replay uncertain input. No installed/live/frame-performance claim yet.
Draft; do not hold the accepted #693 usage fix behind this follow-up.