Skip to content

Delete the duplicated channel Active line - #693

Merged
trissim merged 19 commits into
mainfrom
refactor/remove-channel-active
Oct 16, 2026
Merged

trissim merged 19 commits into
mainfrom
refactor/remove-channel-active

Conversation

@trissim

@trissim trissim commented Oct 16, 2026 •

Copy link
Copy Markdown

Change

Delete the channel Active summary widget and its preparation/query path; retain channel mentions and sidebar/tab busy indicators. Paired Core #987: 2fb445b94fc22ed58a365709f4a873ca53e4a303. Current Toad main is normally integrated, including typed Core subscriptions and the current theme pin.

  • Saved context retains Core's required ContextReading and renders status_text(). DM status uses the configuration update's derived status_label; Toad does not join nullable model/context fields.
  • Delete ContextUnavailable completely. Initial state, compaction and unusable live measurements use the existing UnmeasuredContext through SavedContextMeasurement. No Toad-authored unavailable-context reason or nullable wire_fields projection remains in this workflow.
  • Correct the earlier false completeness claim: the preceding head still had FOUR ContextUnavailable references (two in comms_updates.py, two in context_measurement.py). They are now ZERO across src/toad. The unmeasured status sentence is declared once in Core's UnmeasuredContext.status_text(); the unrelated context-explorer error diagnostic is not this measurement state.
  • Keep kind-owned composition: channel kinds compose no activity widget; DM constructs/stores/yields SessionDetails. CommsChatView delegates with yield from, without selecting a kind or branching on a missing widget. The deleted channel activity classes are not replaced with an empty widget.
  • Preserve mention preparation's existing source/target fences. Unread APIs, saved sessions and uncertain inputs are unchanged.

Source evidence and checks

Before/after NRA ModuleSyntaxIndex enumeration is retained by the current owner in core-change-report/.artifacts/sidebar-observation/task-b-{before,after}.json/.log, alongside task-b-toad.diff. Zero parser omissions; spelling-based leads do not resolve computed dispatch and are not behavior proof. The prior owner's ratchet applies only to its preceding head, not this checkpoint.

Final heads: Core 2fb445b94fc22ed58a365709f4a873ca53e4a303, Toad a64bca902416fd7881d9676b79040f134ad513fd. Both existing production debt checks exit 0 with no positive deltas; both source diffs pass whitespace checks. Core's focused ACP codec check has 2 passed in 0.15s, after migrating the newly merged TranscriptDraftUpdate sample and accepting the strict codec's TypeError/ValueError boundary contract. Earlier failures remain retained. The manifest and lock agree; uv lock --check --offline passes.

Actual plain-st/Xvfb :229, using installed runtime toad-4dbaf250c-core-496609b95-native-6468a1979d983e9d-20261016T184023Z with both source overlays: saved native history renders, Core's initial unmeasured text is visible, saved DM history/activity/prompt/model-only status render, #comms renders without an Active summary, and typing an unsent @ shows real mention candidates. The draft was cleared. No crash file or ACP session/prompt was produced. Evidence is in core-change-report/.artifacts/sidebar-observation/task-b-live/. Initial oversized-terminal images cropped the bottom of the view; fitted-window screenshots supersede the mistaken blank-DM report.

This is a demonstrated real-application source-overlay path, NOT shared-installed acceptance or performance proof. Native attachment to the older running Core 496609b95 owner refuses Expected a string family kind; matching reviewed native-owner alignment is still required. No legacy decoder, input replay or manual restart was added. No Toad tests, fixtures, fake responses or synthetic app were used. Review and Codex publication remain required. Model fallback deletion/canonical saved-selection carry is separate unfinished work, not bulk-sidebar acceptance.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Author

P30 follow-up: reused a64bca9 unchanged (original Active-line cut f59aa13: 85 deleted/16 added). The Active string and deleted widget/preparation/update family have zero remaining source references. Genuine saved #comms on plain st/:210 shows no Active row and still marks Working/Thinking sidebar agents: /home/ts/.cache/agent-scratch/toad-sidebar-frame-owner/p30-active-line/channel-busy-sidebar-settled.png. Current T190524Z with this Toad source plus clean Core 2fb source overlay; no source edits, tests, provider input or replay. Frontend/st exited normally. This demonstrates the requested channel path, not shared-installed acceptance: native attachment still rejects Expected a string family kind, retained in /home/ts/.local/state/toad/logs/Sidebar_frame_owner_baseline_2026-10-16T15_10_39_669654.txt:5. ContextReading/native alignment remains with change-report; its source and Core pin are preserved.

@trissim
trissim merged commit 8335301 into main Oct 16, 2026
1 of 2 checks passed
@trissim
trissim deleted the refactor/remove-channel-active branch October 19, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant