Repository navigation
Conversation
This was referenced Oct 16, 2026
Author
|
Superseded by the corrected kind-owned composition folded into #693. The source checkpoint remains published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Follow-up to #693, based on its78361008 head. The Core status-owner fix stays on #693; this does not change it or
unread().The 0-or-1 widget-class tuple was an Optional disguised as a collection. Delete that factory loop and make each kind choose actual composition:
ConversationKind.compose_activity(view);CommsChatView.compose_dm_activity, where the view constructs/owns/yields itsSessionDetailswith the required history/status source;Do not reset channel
thread_activityto None:ThreadStatusOwneralready owns that absent default. No empty widget, extra state, or factory mutating its caller.Evidence
Compared with #693: two production files, +15/−12.
activity_widgets: three declarations + one consumer →0. Shared widget-class construction loop1→0. Kind-side widget import1→0. View-owned DM composition0→1. No new channel status-field assignment.status_text, mentions, unread handling, history and Core pin are unchanged from #693.NRA Package source enumeration covered Toad281/Core328/Textual254 modules: 863 parsed, zero omissions. Before/after declarations, writes, decisions, inheritance/imports and consumers:
.artifacts/channel-active/composition-{before,after}.txt, including the actualThreadStatusOwnerdeclaration/consumers. Dynamic composition callbacks/MRO are not proved by AST; their implementations were read separately.Receiving ratchet against78361008 exit0, no positive deltas. ForeignAbsenceProbe: kind6→6, chat3→3. Output
.artifacts/channel-active/composition-ratchet.json.No automated Toad tests, fixtures or source-overlay application. Real DM/channel composition verification awaits approved normal installation with #693/Core#987, using the accepted XvfbDisplay.input helper by path. No installed/live-success claim. Draft for Claude review; do not merge independently ahead of #693.