[vertexodessa]

The OSD read the flight mode as an ArduPlane custom_mode number, but mavlink.cpp already converts it to the FLIGHT_MODE_* values from mavlink.h. So only STABILIZE was right (it's 2 in both). ACRO showed Unknown, MANUAL showed CIRCLE, RTL showed FLY_BY_WIRE_A, FBWA showed AUTO.

The switch now uses the FLIGHT_MODE_* values, one to one with mavlink.h.

One visible change: a mode mavlink.cpp doesn't know (e.g. a non-ArduPlane FC) stays 0, which used to show as MANUAL and now shows Unknown.

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Fix OSD flight mode names

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Match OSD flight mode names to the normalized values supplied by MAVLink telemetry.
• Show Unknown instead of MANUAL when the flight mode is unrecognized.

Diagram

graph TD
  Heartbeat["MAVLink heartbeat"] --> Decoder["Mode conversion"] --> Telemetry["MavlinkData"] --> OSD["OSD mode lookup"] --> Display["Flight mode label"]

Loading

High-Level Assessment

Correcting the OSD lookup at the consumer is appropriate because the native heartbeat handler already converts custom modes. Changing that conversion or introducing a shared cross-language mode registry would add scope without addressing a separate need.

Files changed (1) +21 / -20

Bug fix (1) +21 / -20

OSDManager.javaKey OSD flight mode names by normalized mode values +21/-20

Key OSD flight mode names by normalized mode values

• Replaces the ArduPlane custom-mode cases with names aligned to the FLIGHT_MODE values carried by MavlinkData. A zero or otherwise unmatched value now displays Unknown rather than MANUAL.

app/src/main/java/com/openipc/pixelpilot/osd/OSDManager.java