Queue lifecycle rejection diagnostics outside blocking I/O - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An illegal-transition diagnostic called the console logger while holding the lifecycle mutex, allowing a blocked output sink to stop independent decisions. Rejections now enqueue a bounded
daemon/errrecord in the affected unit's journal, carrying its invocation and manager origin. Accepted state stays unchanged. The existing journal writer, capacity/loss counters and close ownership handle persistence; no new writer class is introduced.Diagnostic text is capped at 4096 UTF-8 bytes, with truncation marked. One shared diagnostic group uses the normal invocation byte/record allowance. Journal origins publish as immutable atomic copies so diagnostic admission never waits for the storage mutex.
Validation: the blocked-console regression fails on the previous implementation and now permits snapshots, independent start/stop and manager close. Storage-stall pressure verifies bounded admission, loss reporting, immutable origin/invocation identity, UTF-8 truncation and persisted records. Twenty focused race repetitions, the full uncached race suite, vet and Windows/Linux staticcheck passed. Three combined repetitions passed after integration. Exact source
2d0f6f3dc45eff130fc23415d35c5d51d933b7e3passed CI run 34765837025 and six cases ten times each under SYSTEM and a headless standard user, with no skips and full fixture cleanup. Both package binary hashes and source identity were verified in the retained qualification evidence. Broader daemon output and Windows event resources remain R5 work.