Keep captured journal stream identity separate from severity - #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw stderr was always stored as an error and stdout as informational, even though neither stream establishes an application's log level. Journal v4 now preserves stdout/stderr identity with unknown severity. Explicit supervisor diagnostics keep their supplied level. Mixed v1-v4 reading preserves existing values and bytes without reclassifying historical records; the record field layout remains compatible with the previous winunitd reader.
Regression tests reproduce the old inference and verify actual capture, mixed legacy/current files, explicit diagnostic levels, manager logs API/user origin and native Windows stdout/stderr. The versioned behavior and consumer interpretation are documented.
Validation: full local race suite passed (journal 51.472s, manager 63.073s), vet and Windows/Linux staticcheck passed, twenty focused schema/capture repetitions passed in 2.797s, and ten final native/API/legacy manager repetitions passed in 3.214s. Complete ten-file diff/source/privacy review, eleven local links/anchors and whitespace checks passed. Baseline failures are retained privately.
Exact-source CI 34776680148 passed for a576ef2. Disposable Windows qualification passed 59 cases three times per SYSTEM/headless-standard-user identity with no skips, one logical CPU, GOMAXPROCS=1 and test parallelism=1 (56.811s / 54.691s). Four binary hashes, clean source/module identity and final fixture/process/profile/linger cleanup were verified. Raw evidence is retained privately. The disk-retention prerequisite is merged in #215; broader durable diagnostics, combined stress and later installation/pilot gates remain open.