feat: Add new model and data for Encounter Pokemon Details#1621
Open
jemarq04 wants to merge 24 commits into
Open
feat: Add new model and data for Encounter Pokemon Details#1621jemarq04 wants to merge 24 commits into
jemarq04 wants to merge 24 commits into
Conversation
…/add-encounter-details
…r encounter_pokemon_details
jemarq04
marked this pull request as draft
July 24, 2026 20:15
jemarq04
marked this pull request as ready for review
July 24, 2026 23:03
Naramsim
reviewed
Jul 25, 2026
| @@ -0,0 +1,146 @@ | |||
| encounter_id,min_perfect_ivs,always_shiny,never_shiny,is_alpha | |||
Member
There was a problem hiding this comment.
Instead of always shiny/never shiny we could use a percentage number? like shiny and then a value ranging from 0 to 100 or from 0 to 1?
| @@ -0,0 +1,146 @@ | |||
| encounter_id,min_perfect_ivs,always_shiny,never_shiny,is_alpha | |||
Member
There was a problem hiding this comment.
It's the first time we explicity add IVs in our API. I heard about them but not sure how they are calculated, I think there's a difficult formula.
questions, can these IVs be calculated with our API? Second, how did you calculate the values you added in the CSV?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
I've added a new
EncounterPokemonDetailmodel along withencounter_pokemon_details.csvto add in additional (optional) fields to describe the Pokemon in certain encounters. For now, this includes information like guaranteed perfect IVs, whether or not it is always shiny/non-shiny, and whether or not the Pokemon is an Alpha (helpful as I begin PLA encounters).In the future, this could maybe help specify natures or movesets from gift encounters if we want to expand to include that, so I think this file can help with those additional details.
When doing this, I encountered errors making the new migration file due to some problems with the changes to the berry models in #1572, so I just marked some fields as nullable in the model.
So far, I've just added details for Pokemon that are always/never shiny to the new
encounter_pokemon_details.csvfile. Checking local builds show that it seems to work and lists thepokemon_detailsfield as a list ofdictobjects, just afterencounter_conditions. If there are any suggestions on the structure otherwise, let me know.In adding these details, I found some duplicate encounters in SM/USUM and an unexpected Xerneas/Yveltal encounter in the wrong game, so I removed those from the
encounters.csvfile.AI coding assistance disclosure
No AI was used.
Contributor check list