-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Add new model and data for Encounter Pokemon Details #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jemarq04
wants to merge
24
commits into
PokeAPI:master
Choose a base branch
from
jemarq04:feat/add-encounter-details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f0cf373
feat: add models and serializers for new encounter_pokemon_details.cs…
jemarq04 a17927d
feat: remove min_perfect_evs field
jemarq04 7ccf092
fix: remove xerneas encounter in Y and yveltal encounter in X
jemarq04 5c5e741
fix: remove duplicate tapu legendary encounters in SM and USUM
jemarq04 79b3652
fix: remove duplicate solgaleo/lunala encounters in SM
jemarq04 77123e0
fix: remove additional static encounters for nihilego in SM
jemarq04 d85d7a9
fix: remove duplicate buzzwole encounters in SM
jemarq04 8ca5f97
fix: remove duplicate xurkitree encounteres in SM
jemarq04 5282259
fix: remove duplicate celesteela and kartana encounters in SM
jemarq04 cb96266
fix: remove duplicate guzzlord encounters in SM
jemarq04 d1fef30
fix: remove duplicate encounters for solgaleo/lunala in USUM
jemarq04 5fb0290
feat: add encounter pokemon details for always_shiny encounters
jemarq04 7147403
feat: add shiny-locked encounter pokemon details
jemarq04 a40de50
feat: update pokemon_details field to include all values, not just tr…
jemarq04 e50810a
merge: Merge branch 'master' of github.com:jemarq04/pokeapi into feat…
jemarq04 6323fdf
fix: correct nullability of berry fields from recent PR
jemarq04 d5dcb58
feat: rename migration script
jemarq04 86b90a5
feat: add pokemon_details to check_encounters.py script
jemarq04 9c4d256
fix: remove unused setup classmethod for pokemon details
jemarq04 68e4f18
tests: add test to ensure only one entry per encounter_id is found fo…
jemarq04 be0e273
feat: update structure of pokemon_details field
jemarq04 cda74c5
feat: change default value for pokemon_details field
jemarq04 fd8b51c
merge: Merge branch 'master' of github.com:jemarq04/pokeapi into feat…
jemarq04 425590b
fix: re-generate openapi.yml file after fix to berry schema updates
jemarq04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| encounter_id,min_perfect_ivs,always_shiny,never_shiny,is_alpha | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's the first time we explicity add IVs in our API. I heard about them but not sure how they are calculated, I think there's a difficult formula. questions, can these IVs be calculated with our API? Second, how did you calculate the values you added in the CSV? |
||
| 62288,,1,0,0 | ||
| 62289,,1,0,0 | ||
| 62290,,1,0,0 | ||
| 62291,,1,0,0 | ||
| 62292,,1,0,0 | ||
| 63735,,0,1,0 | ||
| 63736,,0,1,0 | ||
| 64082,,0,1,0 | ||
| 64086,,0,1,0 | ||
| 64462,,0,1,0 | ||
| 64463,,0,1,0 | ||
| 64464,,0,1,0 | ||
| 64465,,0,1,0 | ||
| 64466,,0,1,0 | ||
| 64467,,0,1,0 | ||
| 64706,,0,1,0 | ||
| 64707,,0,1,0 | ||
| 64746,,0,1,0 | ||
| 64763,,0,1,0 | ||
| 64832,,0,1,0 | ||
| 64944,,0,1,0 | ||
| 64948,,0,1,0 | ||
| 65073,,0,1,0 | ||
| 65081,,0,1,0 | ||
| 65960,,0,1,0 | ||
| 65964,,0,1,0 | ||
| 65979,,0,1,0 | ||
| 65980,,0,1,0 | ||
| 65981,,0,1,0 | ||
| 65982,,0,1,0 | ||
| 65983,,0,1,0 | ||
| 65984,,0,1,0 | ||
| 65985,,0,1,0 | ||
| 65986,,0,1,0 | ||
| 65987,,0,1,0 | ||
| 65988,,0,1,0 | ||
| 65989,,0,1,0 | ||
| 65990,,0,1,0 | ||
| 65991,,0,1,0 | ||
| 65992,,0,1,0 | ||
| 65993,,0,1,0 | ||
| 65994,,0,1,0 | ||
| 66210,,0,1,0 | ||
| 66216,,0,1,0 | ||
| 66558,,0,1,0 | ||
| 66577,,0,1,0 | ||
| 66585,,0,1,0 | ||
| 66627,,0,1,0 | ||
| 66628,,0,1,0 | ||
| 66655,,0,1,0 | ||
| 66656,,0,1,0 | ||
| 66657,,0,1,0 | ||
| 66658,,0,1,0 | ||
| 66731,,0,1,0 | ||
| 66732,,0,1,0 | ||
| 66739,,0,1,0 | ||
| 66742,,0,1,0 | ||
| 66767,,0,1,0 | ||
| 66768,,0,1,0 | ||
| 66769,,0,1,0 | ||
| 66770,,0,1,0 | ||
| 66852,,0,1,0 | ||
| 66853,,0,1,0 | ||
| 66854,,0,1,0 | ||
| 66855,,0,1,0 | ||
| 66856,,0,1,0 | ||
| 66857,,0,1,0 | ||
| 66858,,0,1,0 | ||
| 66859,,0,1,0 | ||
| 66860,,0,1,0 | ||
| 66861,,0,1,0 | ||
| 66994,,0,1,0 | ||
| 66995,,0,1,0 | ||
| 70090,,0,1,0 | ||
| 70091,,0,1,0 | ||
| 75309,,0,1,0 | ||
| 75310,,0,1,0 | ||
| 75886,,0,1,0 | ||
| 75887,,0,1,0 | ||
| 75888,,0,1,0 | ||
| 75889,,0,1,0 | ||
| 75890,,0,1,0 | ||
| 75891,,0,1,0 | ||
| 75892,,0,1,0 | ||
| 75893,,0,1,0 | ||
| 75894,,0,1,0 | ||
| 75895,,0,1,0 | ||
| 75912,,0,1,0 | ||
| 75913,,0,1,0 | ||
| 75914,,0,1,0 | ||
| 75915,,0,1,0 | ||
| 75916,,0,1,0 | ||
| 75917,,0,1,0 | ||
| 75918,,0,1,0 | ||
| 75919,,0,1,0 | ||
| 75920,,0,1,0 | ||
| 75921,,0,1,0 | ||
| 75922,,0,1,0 | ||
| 75923,,0,1,0 | ||
| 75924,,0,1,0 | ||
| 75925,,0,1,0 | ||
| 75926,,0,1,0 | ||
| 75927,,0,1,0 | ||
| 75928,,0,1,0 | ||
| 75929,,0,1,0 | ||
| 75930,,0,1,0 | ||
| 75931,,0,1,0 | ||
| 75932,,0,1,0 | ||
| 75933,,0,1,0 | ||
| 75934,,0,1,0 | ||
| 75935,,0,1,0 | ||
| 75936,,0,1,0 | ||
| 75937,,0,1,0 | ||
| 75938,,0,1,0 | ||
| 75939,,0,1,0 | ||
| 75940,,0,1,0 | ||
| 75941,,0,1,0 | ||
| 75942,,0,1,0 | ||
| 75943,,0,1,0 | ||
| 75896,,0,1,0 | ||
| 75897,,0,1,0 | ||
| 75898,,0,1,0 | ||
| 75899,,0,1,0 | ||
| 75900,,0,1,0 | ||
| 75901,,0,1,0 | ||
| 75910,,0,1,0 | ||
| 75911,,0,1,0 | ||
| 75944,,0,1,0 | ||
| 75945,,0,1,0 | ||
| 75946,,0,1,0 | ||
| 75947,,0,1,0 | ||
| 97808,,0,1,0 | ||
| 97809,,0,1,0 | ||
| 97810,,0,1,0 | ||
| 97811,,0,1,0 | ||
| 97812,,0,1,0 | ||
| 97813,,0,1,0 | ||
| 99316,,0,1,0 | ||
| 99317,,0,1,0 | ||
| 99348,,0,1,0 | ||
| 99349,,0,1,0 | ||
| 99350,,0,1,0 | ||
| 99351,,0,1,0 | ||
| 99352,,0,1,0 | ||
| 99353,,0,1,0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Generated by Django 5.2.10 on 2026-07-24 16:35 | ||
|
|
||
| import django.db.models.deletion | ||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("pokemon_v2", "0030_alter_berry_growth_time_alter_berry_max_harvest_and_more"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.CreateModel( | ||
| name="EncounterPokemonDetail", | ||
| fields=[ | ||
| ( | ||
| "id", | ||
| models.AutoField( | ||
| auto_created=True, | ||
| primary_key=True, | ||
| serialize=False, | ||
| verbose_name="ID", | ||
| ), | ||
| ), | ||
| ("min_perfect_ivs", models.IntegerField(blank=True, null=True)), | ||
| ("always_shiny", models.BooleanField(default=False)), | ||
| ("never_shiny", models.BooleanField(default=False)), | ||
| ("is_alpha", models.BooleanField(default=False)), | ||
| ( | ||
| "encounter", | ||
| models.ForeignKey( | ||
| blank=True, | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| to="pokemon_v2.encounter", | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of always shiny/never shiny we could use a percentage number? like
shinyand then a value ranging from 0 to 100 or from 0 to 1?