Repository navigation
Conversation
The BBQuests enum lived in Options/PokemonSV_BBQOption.h, but its slug
map and string_to_enum lived in Programs/Farming/
PokemonSV_BlueberryQuests.{h,cpp}. Anything that needed a quest name
had to depend on the whole BBQ program module, and
BlueberryCatchPhoto.h included BlueberryQuests.h only for these types
while BlueberryQuests.cpp included BlueberryCatchPhoto.h.
Move the enum and slug mapping into Options/PokemonSV_BBQuests.{h,cpp},
next to BBQOption.h, which now includes it. Add
BBQuests_enum_to_string, backed by a reverse map built once from the
existing slug map.
Move CameraAngle into BlueberryCatchPhoto.h, its only user. The
catch/photo module no longer includes BlueberryQuests.h.
No behavior change. Add a unit test that every quest round-trips
through its slug.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
BBQ failures are hard to attribute to a specific quest and attempt from the existing logs. Add one-line "BBQ ..." events: - board: panel detected and quest slugs in board order, each time read_quests() reads the panel - per attempt: start, route_return and result, with attempt/limit and route, verification and total durations - catch battle-entry timeout, and retry exhaustion BBQLogger depends only on Logger and the Options/PokemonSV_BBQuests leaf, so the quest and catch/photo modules call into it without a dependency back. Durations use explicit steady_clock timestamps so tests can check them without depending on wall-clock time. Add four PokemonSV::BBQDiagnosticLogs tests with a recording logger covering board formatting, success, failure with retry exhaustion, and long/zero durations. Controller sequences, retry limits and reroll policy are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
When a catch quest times out entering battle, or a quest is still on the panel after an attempt, the logs say what failed but not what the screen showed. Add save_bbq_snapshot(), which saves the current frame to DEBUG_PATH()/BBQ/ as <timestamp>-<quest>-<reason>.png and logs a "BBQ event=snapshot" line with the outcome. Unlike dump_image(), it stays on the local machine and sends nothing to telemetry. Call it at the battle-entry timeout and at failed quest verification. Add PokemonSV::BBQSnapshot tests that save into a folder that does not exist yet and check the file, path and log line, and that check a save that cannot be written returns no path and logs saved=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/failure-screenshots
branch
from
October 21, 2026 05:18
92ad223 to
f07244e
Compare
This was referenced Oct 22, 2026
Contributor
Author
|
Closing for now to keep the upstream queue to PRs that are ready: this one waits on unmerged parent PRs. It continues on my fork as dayfine#3, and I'll reopen it here once its parents merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a catch quest times out entering battle, or a quest is still on the panel after an attempt, the logs say what failed but not what the screen showed.
Changes
Programs/Farming/PokemonSV_BBQSnapshot.{h,cpp}:save_bbq_snapshot(logger, frame, directory, quest, reason)saves the frame as<timestamp>-<quest>-<reason>.pngand logsBBQ event=snapshot saved=<0|1> path=.... It returns the path, or an empty string if nothing was written.bbq_snapshot_directory()isDEBUG_PATH()/BBQ/.dump_image(), this stays on the local machine and sends nothing to telemetry.battle-entry-timeout) and failed quest verification (verification-failed). In both cases it saves the current frame.PokemonSV::BBQSnapshottests write to a temp folder:saved=0Validation
Native arm64 macOS build of the full app passes. Both snapshot tests pass, along with the #1625 and #1631 tests. No new Switch run for this version. An earlier version of these capture points was checked on Switch 1.
Controller sequences, retry limits and reroll policy are unchanged.
🤖 Generated with Claude Code