Repository navigation
Conversation
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 20, 2026 22:30
155646c to
4ce2d5d
Compare
Collaborator
|
Do you have a screenshot of the failing OCR read (remember to use the Screenshot button to get accurate screenshots)? If so, you can then add it to the test suite. |
dayfine
commented
Oct 21, 2026
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 21, 2026 02:01
23f3f9d to
4aa5a95
Compare
dayfine
commented
Oct 21, 2026
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 21, 2026 02:57
4aa5a95 to
c0d2540
Compare
Contributor
Author
The BBQuests enum lived in Options/PokemonSV_BBQOption.h, but its slug
map and string_to_enum lived in Programs/Farming/
PokemonSV_BlueberryQuests.{h,cpp}. Anything that needed a quest name
had to depend on the whole BBQ program module, and
BlueberryCatchPhoto.h included BlueberryQuests.h only for these types
while BlueberryQuests.cpp included BlueberryCatchPhoto.h.
Move the enum and slug mapping into Options/PokemonSV_BBQuests.{h,cpp},
next to BBQOption.h, which now includes it. Add
BBQuests_enum_to_string, backed by a reverse map built once from the
existing slug map.
Move CameraAngle into BlueberryCatchPhoto.h, its only user. The
catch/photo module no longer includes BlueberryQuests.h.
No behavior change. Add a unit test that every quest round-trips
through its slug.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 21, 2026 03:27
c0d2540 to
50d9264
Compare
BBQ failures are hard to attribute to a specific quest and attempt from the existing logs. Add one-line "BBQ ..." events: - board: panel detected and quest slugs in board order, each time read_quests() reads the panel - per attempt: start, route_return and result, with attempt/limit and route, verification and total durations - catch battle-entry timeout, and retry exhaustion BBQLogger depends only on Logger and the Options/PokemonSV_BBQuests leaf, so the quest and catch/photo modules call into it without a dependency back. Durations use explicit steady_clock timestamps so tests can check them without depending on wall-clock time. Add four PokemonSV::BBQDiagnosticLogs tests with a recording logger covering board formatting, success, failure with retry exhaustion, and long/zero durations. Controller sequences, retry limits and reroll policy are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 21, 2026 03:32
50d9264 to
0ceac54
Compare
Mysticial
requested review from
kichithewolf
and removed request for
kichithewolf
October 21, 2026 05:39
Collaborator
|
Can you delete the dialogues of you talking to your Claude on the PR? That makes it difficult to know what are the comments reviewers should follow 😃 |
This was referenced Oct 22, 2026
Contributor
Author
|
Closing for now to keep the upstream queue to PRs that are ready: this one waits on unmerged parent PRs. It continues on my fork as dayfine#2, and I'll reopen it here once its parents merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BBQ failures are hard to attribute to a specific quest and attempt from the existing logs. This adds one-line
BBQ ...diagnostic events.Changes
Programs/Farming/PokemonSV_BBQLogger.{h,cpp}depends only onLoggerandOptions/PokemonSV_BBQuests.h(from PokemonSV: move BBQ quest identity into its own Options module #1631). The quest and catch/photo modules call into it, and nothing points back.BBQLogger::board(): whether the panel was detected, and the quest slugs in board order. Called fromread_quests().BBQLogger::battle_entry_timeout()andretry_exhausted().BBQAttemptLog: start / route_return / result for each attempt, with attempt/limit, and route, verification and total durations in both ms and a readable form (duration_to_string).unknown.PokemonSV::BBQDiagnosticLogstests use a recording logger and fixedsteady_clocktimestamps. They cover board formatting, success, failure with retry exhaustion, and long/zero durations.Example:
Validation
Native arm64 macOS build of the full app passes. The 4 BBQDiagnosticLogs tests and #1631's round-trip test pass. No new Switch trial was run for this rework.
Scope
Controller sequences, retry limits and reroll policy are unchanged. Logging the BP balance on the board event will be a small follow-up once #1628 (BP OCR crop) merges. Failure screenshots are in #1629.
🤖 Generated with Claude Code