Repository navigation
PokemonSV: move BBQ quest identity into its own Options module - #1631
Merged
Merged
Conversation
dayfine
force-pushed
the
bbq/quest-identity
branch
from
October 21, 2026 03:24
445a933 to
e36342f
Compare
dayfine
marked this pull request as ready for review
October 21, 2026 03:26
Contributor
Author
|
@jw098 PTAL |
This was referenced Oct 22, 2026
Closed
dayfine
force-pushed
the
bbq/quest-identity
branch
from
October 26, 2026 17:55
e36342f to
bce23cd
Compare
kichithewolf
approved these changes
Oct 26, 2026
The BBQuests enum lived in Options/PokemonSV_BBQOption.h, but its slug
map and string_to_enum lived in Programs/Farming/
PokemonSV_BlueberryQuests.{h,cpp}. Anything that needed a quest name
had to depend on the whole BBQ program module, and
BlueberryCatchPhoto.h included BlueberryQuests.h only for these types
while BlueberryQuests.cpp included BlueberryCatchPhoto.h.
Move the enum and slug mapping into Options/PokemonSV_BBQuests.{h,cpp},
next to BBQOption.h, which now includes it. Add
BBQuests_enum_to_string, backed by a reverse map built once from the
existing slug map.
Move CameraAngle into BlueberryCatchPhoto.h, its only user. The
catch/photo module no longer includes BlueberryQuests.h.
No behavior change. Add a unit test that every quest round-trips
through its slug.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/quest-identity
branch
from
October 27, 2026 01:25
bce23cd to
6c312f2
Compare
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Oct 30, 2026
main moved the quest token map, BBQuests_string_to_enum/enum_to_string and CameraAngle out of BlueberryQuests (PokemonAutomation#1631), and the BP crop into read_BP_from_image (PokemonAutomation#1628). Took main's versions and kept only this branch's log_bbq_snapshot() in BlueberryQuests; BlueberryCatchPhoto.cpp now includes BlueberryQuests.h directly, since its header no longer pulls it in. Unknown quests now log as an empty slug (main's enum_to_string) instead of "unknown". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
BBQuestsenum and its slug table out of the BBQ Farmer program intoOptions/PokemonSV_BBQuests.{h,cpp}, so code that only needs a quest name doesn't depend on the whole program module. No behavior change. About 80% of the diff is moved code:git diff --color-moved=dimmed-zebra main...pr-1631. AddsBBQuests_enum_to_string()and a slug round-trip test.Part of PokemonAutomation/ComputerControl#263.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E