Skip to content

PokemonSV: test the Blueberry quest detector on reference frames - #1759

Closed
dayfine wants to merge 2 commits into
PokemonAutomation:mainfrom
dayfine:bbq/quest-detector-tests
Closed

dayfine wants to merge 2 commits into
PokemonAutomation:mainfrom
dayfine:bbq/quest-detector-tests

Conversation

@dayfine

@dayfine dayfine commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Depends on #1754

BlueberryQuestDetector, the OCR the BBQ Farmer uses to read its quests, had no tests. The two Traditional Chinese quest panel frames that #1628 added for the BP reader also show three quests each, so this adds 16 PokemonSV::BlueberryQuestDetector cases to the BBQ farmer's own tests file: every slot of both frames at 1080p and 720p, with the empty fourth slot expected to read as nothing. One frame shows 捕捉1隻… where the dictionary has 捕捉一隻…, so the tests also cover the fuzzy match accepting that. All 16 pass locally alongside the other BBQ tests; like Chinese OCR in the app, they need the PaddleOCR detection model ("PaddleOCRDetection" in Settings → Resources).

Part of PokemonAutomation/ComputerControl#263.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 2 commits October 28, 2026 13:34
PokemonSV_Tests.cpp registers every SV test, and each BBQ change adds
its tests there, so parallel BBQ changes all conflict in it. Move the
BBQ tests unchanged into Programs/Farming/PokemonSV_BBQTests.cpp,
registered through one add_tests_BBQ() call, following the
add_tests_<Module>() pattern the detectors use: the Tera encounter
tests, the quest slug round trip and the Blueberry Points reader tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The two Traditional Chinese quest panel frames added for the BP reader
also show three quests each. Read every slot at 1080p and 720p, and
check that the empty fourth slot reads as nothing. The tests sit in the
BBQ farmer's tests file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/quest-detector-tests branch from d01ac30 to 44e2a87 Compare October 28, 2026 20:37
@dayfine
dayfine marked this pull request as ready for review October 28, 2026 20:42
@dayfine
dayfine marked this pull request as draft October 28, 2026 20:44
@dayfine dayfine closed this Oct 31, 2026
@dayfine
dayfine deleted the bbq/quest-detector-tests branch November 3, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant