Repository navigation
Conversation
dayfine
marked this pull request as draft
October 28, 2026 20:26
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 28, 2026 20:33
5d0cb36 to
d01ac30
Compare
PokemonSV_Tests.cpp registers every SV test, and each BBQ change adds its tests there, so parallel BBQ changes all conflict in it. Move the BBQ tests unchanged into Programs/Farming/PokemonSV_BBQTests.cpp, registered through one add_tests_BBQ() call, following the add_tests_<Module>() pattern the detectors use: the Tera encounter tests, the quest slug round trip and the Blueberry Points reader tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The two Traditional Chinese quest panel frames added for the BP reader also show three quests each. Read every slot at 1080p and 720p, and check that the empty fourth slot reads as nothing. The tests sit in the BBQ farmer's tests file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 28, 2026 20:37
d01ac30 to
44e2a87
Compare
dayfine
marked this pull request as ready for review
October 28, 2026 20:42
dayfine
marked this pull request as draft
October 28, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1754
BlueberryQuestDetector, the OCR the BBQ Farmer uses to read its quests, had no tests. The two Traditional Chinese quest panel frames that #1628 added for the BP reader also show three quests each, so this adds 16PokemonSV::BlueberryQuestDetectorcases to the BBQ farmer's own tests file: every slot of both frames at 1080p and 720p, with the empty fourth slot expected to read as nothing. One frame shows捕捉1隻…where the dictionary has捕捉一隻…, so the tests also cover the fuzzy match accepting that. All 16 pass locally alongside the other BBQ tests; like Chinese OCR in the app, they need the PaddleOCR detection model ("PaddleOCRDetection" in Settings → Resources).Part of PokemonAutomation/ComputerControl#263.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E