Repository navigation
[BDSP] MenuDetector & ShortDialogDetector early game fixes - #1862
Merged
Mysticial merged 2 commits intoNov 7, 2026
Merged
Conversation
…epts a long first line ShortDialogDetector missed dialogue whose long first line covers the white box it checks at the right end (Rowan's "Now, go on, and leap into the world of Pokemon!"). It keeps the old check and also accepts the box's right end below the first line, so every screen it accepted before is still accepted. MenuDetector's columns start a little further right (0.160 to 0.166), in the gap after each icon: with a NEW tag on TOWN MAP the second column took the edge of the tag and the menu went unseen. Adds image tests for both, read from PokemonBDSP/DialogDetector and PokemonBDSP/MenuDetector in CommandLineTests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Collaborator
|
I manually tested this PR on:
and it they still work. So merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update BDSP MenuDetector / ShortDialogDetector to handle early game UIs.
Images checked in PokemonAutomation/CommandLineTests#42, which are from new-game, Jubilife and Floaroma runs on a Switch through a 1080p capture card, where both fixes were used.