Skip to content

[BDSP] MenuDetector & ShortDialogDetector early game fixes - #1862

Merged
Mysticial merged 2 commits into
PokemonAutomation:mainfrom
dayfine:handoff/bdsp-detectors-152
Nov 7, 2026
Merged

Mysticial merged 2 commits into
PokemonAutomation:mainfrom
dayfine:handoff/bdsp-detectors-152

Conversation

@dayfine

@dayfine dayfine commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Update BDSP MenuDetector / ShortDialogDetector to handle early game UIs.

  • Short menu in new game / New icon for menu item unlocked earlier in the story
  • Edge cases with Professor Rowan's opening line

Images checked in PokemonAutomation/CommandLineTests#42, which are from new-game, Jubilife and Floaroma runs on a Switch through a 1080p capture card, where both fixes were used.

dayfine and others added 2 commits November 7, 2026 11:49
…epts a long first line

ShortDialogDetector missed dialogue whose long first line covers the white
box it checks at the right end (Rowan's "Now, go on, and leap into the world
of Pokemon!"). It keeps the old check and also accepts the box's right end
below the first line, so every screen it accepted before is still accepted.

MenuDetector's columns start a little further right (0.160 to 0.166), in the
gap after each icon: with a NEW tag on TOWN MAP the second column took the
edge of the tag and the menu went unseen.

Adds image tests for both, read from PokemonBDSP/DialogDetector and
PokemonBDSP/MenuDetector in CommandLineTests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@Mysticial

Copy link
Copy Markdown
Collaborator

I manually tested this PR on:

  • Starter Reset
  • Legendary Reset
  • Egg Autonomous

and it they still work. So merging.

@Mysticial
Mysticial merged commit 15f0450 into PokemonAutomation:main Nov 7, 2026
8 checks passed
@dayfine
dayfine deleted the handoff/bdsp-detectors-152 branch November 7, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants