Repository navigation
build: commit Cargo.lock and build with --locked - #18
Merged
Merged
Conversation
Spotter is an application, and without a lockfile every CI run and every release resolved its dependencies afresh, so a release could not be rebuilt from its tag and a new upstream version could change a published binary without any commit. CI and the release legs now build with --locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotter ignored its Cargo.lock, so every CI run and every release resolved dependencies afresh: a release could not be rebuilt from its tag, and a new upstream version could change a published binary without any commit. Cargo recommends committing the lockfile for applications, and SignPath expects builds to be reproducible from source.
Checked locally: cargo test --locked passes (146 tests).