Split-TU: extract SlotForInlineClosureAndFirstClassCallableCallArgResolvers (#36387) - #37058
Merged
PurHur merged 1 commit intoSep 6, 2026
Merged
Conversation
…olvers (#36387) Move closure / first-class-callable call-arg slot resolvers (~460 lines) out of SlotForCallArgResolvers so gen-0 split-TU can hollow a smaller Concern TU. Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1148→1151 and spine 8345→8347. Move-only — mirrors php-src Zend/zend_compile.c Closure / FROM_CALLABLE argument send wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-36387-slot-for-inline-closure-fcc-resolvers
branch
September 6, 2026 20:05
This was referenced Sep 6, 2026
PurHur
added a commit
that referenced
this pull request
Sep 6, 2026
…vers (#36387) (#37061) Move hoisted property / ClassConstFetch / Closure::bind New_ this / inline-new enum-case call-arg SEND slot resolvers (~450 lines) out of SlotForCallArgResolvers so gen-0 split-TU can hollow a smaller Concern TU. Complementary to SlotForInlineClosureAndFirstClassCallableCallArgResolvers (#37058). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget and spine 8347→8348. Move-only — mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlotForInlineClosureAndFirstClassCallableCallArgResolvers(slotForRecentClosureCallArg→resolvePrecedingClosureCallArgSlot, ~460 lines) fromSlotForCallArgResolversso gen-0 split-TU can hollow a smaller Concern TU.Zend/zend_compile.cClosure /FROM_CALLABLEargument send wiring. Complementary to Split-TU: extract RewireHoistedPreludePregCombineAndVarExportCallArgSendSlots (#36387) #37055 HoistedPrelude rewire extract.Test plan
./script/phpunit.sh --filter 'BootstrapSelfhostBundleTest|SizeBudget'→ OK (4 tests, 537 assertions)./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OK (spine 8347/8347)script/differential-sweep.sh --aot --repeat 3(move-only extract)Closes nothing (Part of #36387).
Made with Cursor