check static addresses match in pyo3-ffi-check - #6421
Merged
Merged
Conversation
alex
approved these changes
Sep 16, 2026
bschoenmaeckers
approved these changes
Sep 16, 2026
bschoenmaeckers
enabled auto-merge
September 16, 2026 12:37
davidhewitt
added a commit
that referenced
this pull request
Sep 17, 2026
* check static addresses match in `pyo3-ffi-check` * newsfragments * fix private symbols * fmt * fix windows-only pypy symbol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6389, to also fix exported
staticitems alongside functions.Similar to that PR, I just check the addresses of the statics match, which at least catches all link errors.
Disclosure: as this was a fairly mechanical application of existing patterns from this codebase I had local AI produce the diff, however I have reviewed it and cleaned up somewhat; I'm happy with it.