feat: parse Q10 archived map packets - #936
Open
hCoureau wants to merge 2 commits into
Open
Conversation
This was referenced Aug 31, 2026
allenporter
reviewed
Sep 2, 2026
| erase_zones = _parse_erase_zones(tail) | ||
| carpet_mask = _parse_carpet_mask(tail, width, height) | ||
| carpet_mask, carpet_end = _parse_carpet_block(tail, width, height) | ||
| if kind is Q10MapPacketKind.CLEAN_RECORD_DETAIL and carpet_end is not None: |
Contributor
There was a problem hiding this comment.
when this kind of map packet is received, how many of these other fields are also included?
What i'm wondering is if a historical trace kind has a lot of overlap with other fields in Q10MapPacket or if it needs to be a separate type. basically as more fields are added the map packet seems like a sparse object. You could imagine each kind Q10MapPacketKind has a separate dataclass for example, if the overlap is low.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
01/02/03/04archive packet markers with a typed integer enumImportant
This is a stacked pull request based on #933. The isolated change for review is commit
95d268e. After #933 merges, this branch will be rebased ontomainbefore merge so the final diff and history contain only this change.Design against the #933 review priorities
Q10MapPacketmodel for current and archived maps, so consumers do not inspect raw packet markers.Review notes
This split incorporates the earlier review direction on #933: packet kinds own their wire integer values, the packet kind is required and parsed first, and unused trailing packet bytes are not exposed as public state.
No private map captures or account data are included.
Validation
981 passed, including92snapshot testsRelated work
AI assistance disclosure
This contribution was prepared with OpenAI Codex assistance. I reviewed the submitted changes and test results and take responsibility for the contribution.