Skip to content

fix(skill): run examine for an unnamed vendor and finish the vocabulary - #976

Merged
volen-silo merged 1 commit into
mainfrom
fix/doctor-skill-review-followup
Nov 9, 2026
Merged

volen-silo merged 1 commit into
mainfrom
fix/doctor-skill-review-followup

Conversation

@volen-silo

@volen-silo volen-silo commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #909, from its review comments, and then from the review of this PR.

What and why

  • The no-amd-gpu rule had no step that triggers it. fix(skill): state each doctor-skill rule once and rule an unnamed vendor #909 says to ask which GPU the machine has when rocm examine reports no-amd-gpu, but no workflow step ran examine, so a user who named no vendor on a host without an AMD GPU still got has_match: false and an upstream route. Step 1 now runs rocm examine --json first when no vendor is named, and asks which GPU if it reports no-amd-gpu.
  • On WSL2 the status can never be no-amd-gpu. examine answers wsl before it checks for a GPU, so a WSL2 user with, say, an NVIDIA GPU was never asked. Step 1 reads has_amd_gpu there, which is set from the Windows-side detection.
  • The question needs both exits. If the user confirms AMD, or cannot say (for example a container without GPU passthrough), step 1 continues with rocm diagnose, which only reads. If the answer is NVIDIA, Intel or Apple, the scope gate declines.
  • A failed examine is not "go on". examine exits 0 whenever it ran, so a non-zero exit is an error from the CLI. Step 1 relays the error and stops, as the contract check does.
  • The scope gate's closing line and the Workflow intro could override the unnamed-vendor rule. Both said the GPU must be AMD. They now continue for an AMD or an unnamed vendor, pointing at step 1 which checks the host, and decline for NVIDIA, Intel or Apple.
  • "Auto-applicable" was not fully gone. The contract-check paragraph still said "the auto-applicable set", and step 1 showed the auto_applicable flag while step 3 said "has a runner". The paragraph now says which fixes have a runner, and step 3 says what the flag means: true only where fix.class is auto on this host, so false for fix-9-igpu-dgpu and for fix-2-unset-override on Linux and WSL2 (WSL2 runs the same Linux arm).
  • The closing pointer to reference.md is back to covering the full closed catalog, and the skill card's Description is one sentence again, keeping "print-only" for the two vLLM failures.

reference.md, the evals and all tests are untouched. The lines skill_reference parses are intact.

Evidence

  • skillscope v0.1.3 in WSL2 (Ubuntu), opus, on the final text of this PR: behavioral 10/10 cases and 39/39 expectations; rocm-nothing-established-routes-upstream and rocm-vendor-not-named-is-not-declined passed in both of two extra runs; routing 12/12.
  • Scripted scenarios with canned CLI output, one agent, one run each: NVIDIA declined with no commands; no vendor plus no-amd-gpu ran examine, stopped before diagnose and asked which GPU; the user then answering "NVIDIA" was declined; the user confirming AMD in a container went on to rocm diagnose; no vendor plus an AMD GPU found went on to diagnose without asking; fix-2 on WSL2 was reported as print-only with nothing to preview.
  • skillscope structural and the skill_reference tests pass on the rebased branch.

Deferred, and not verified

  • reference.md still says "auto-applicable" in places. It is the e2e fixture and stays untouched here; aligning it is a separate change.
  • Step 0 can still offer the CLI install before examine can report anything, and unsupported-os falls under "any other result: go on". Both are left as they were.
  • Both deferrals below are being filed as follow-up tickets, which I will link here.
  • No eval grades the examine path: the recorded CLI in evals/hooks.py refuses every command except --version, fix --json and diagnose. That needs the harness to answer examine.
  • The scenario runs simulate the CLI from canned output and are single runs. A user who names no vendor now runs one extra command (rocm examine) before diagnose.

Scenario coverage

No Gherkin scenario: this changes agent instructions, not the CLI's output, exit codes, files or runtime selection.

Checklist

  • Bug-fix xfail rows: not a bug fix, n/a.
  • New subcommand or subsystem: n/a.
  • User-facing messages: none changed in the CLI.

@volen-silo
volen-silo requested a review from a team as a code owner November 9, 2026 10:43
@volen-silo
volen-silo requested a review from r0x0r November 9, 2026 10:43

@jussielo-amd jussielo-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This was a static review; I did not run the tests or the evals.

The description holds up against the diff and the CLI source: examine status values, auto_applicable being true only for FixClass::Auto, the gate wording, and the untouched reference.md lines the parser reads. CI is green. The comments are small wording and coverage gaps, none blocking:

  • Non-blocking: the user answering "AMD" after no-amd-gpu has no defined next step.
  • Non-blocking: the Workflow intro still says "the GPU is AMD".
  • Non-blocking: the fix-2 auto_applicable note should say WSL as well as Linux.
  • Non-blocking: step 0 can still offer the CLI install before examine can report no-amd-gpu, and unsupported-os falls under "any other status: go on". Worth a line in the description as deferred, or a follow-up.

🤖 by agenthub on AMD AgentHub

Comment thread skills/rocm-doctor/SKILL.md Outdated

1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json`
first. Status `no-amd-gpu` means the CLI found no AMD GPU: say so, ask which
GPU the machine has, and propose no fix until that is settled. That status

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: this says what happens when no-amd-gpu turns out to be NVIDIA, Intel or Apple (the gate declines), but not what happens when the user answers "AMD" (a container without GPU passthrough, for example). "Propose no fix until that is settled" leaves the next step open, and the scenario runs did not cover that answer. Suggest one clause: "If the user confirms AMD, continue to rocm diagnose."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74. Step 1 now continues with rocm diagnose (which only reads) when the user confirms AMD or cannot say; an answer of NVIDIA, Intel or Apple is declined by the scope gate.

Comment thread skills/rocm-doctor/SKILL.md Outdated
Only continue past this gate when the GPU is AMD.
If the user names no GPU vendor, treat ROCm / HIP wording as AMD and continue;
step 1 checks what the machine has. Continue when the GPU is AMD or no vendor is
named. If the user then says it is NVIDIA, Intel or Apple, decline as above.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: the gate now lets an unnamed vendor through, but the Workflow intro further down (unchanged, so I can't anchor it here) still reads "Only start here once the Scope gate passes — the GPU is AMD." A literal reading still stops an unnamed vendor, which is the conflict this PR removes from the closing gate line. Suggest "…passes — the GPU is AMD or no vendor was named."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74. The Workflow intro now reads "…passes — the GPU is AMD or no vendor was named."

**print-only** (bootloader, kernel, reinstall, Windows driver, …): `rocm fix
<id>` just prints the plan for the user to run themselves — no prompt, and the
CLI never performs those.
CLI never performs those. In a diagnosis, `fix.auto_applicable` is true only

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: fix-2-unset-override is print-only on WSL as well as Linux (PRINT_ON_LINUX_AND_WSL_AUTO_ON_WINDOWS in crates/rocm-core/src/fix/catalog.rs: "WSL runs that same Linux arm"), so auto_applicable is false there too. "on Linux" alone could read as true on WSL. Suggest "on Linux and WSL2" or "anywhere but Windows".

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74. The auto_applicable sentence now says "on Linux and WSL2", and so does the fix-2 bullet in step 3 (WSL2 runs the same Linux arm).

@volen-silo
volen-silo added this pull request to the merge queue Nov 9, 2026

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only change, and the examine step plus the vocabulary fixes check out against main (no-amd-gpu status, auto_applicable semantics, fix-9 NeedsArgument; the contract_version and "other 24 ... print-only" fixture sentences are intact). Three consistency gaps inside SKILL.md need fixing before this lands:

  1. Stale gate preamble (outside the diff hunks, ~line 75). The Workflow preamble still says "Only start here once the Scope gate passes — the GPU is AMD". That contradicts the new rule that an unnamed vendor continues and that step 1 is what checks the machine. Please reword it (e.g. "AMD, or no vendor named").
  2. Step 1 dead end (inline). The question is asked, but the "AMD" answer has no stated next step.
  3. fix-2 wording (inline). It is also print-only on WSL.

Non-blocking: the evidence is canned single-run simulations and no eval covers the new examine path (the PR body acknowledges this). Also, no-amd-gpu is a plausible host state for in-scope failures such as a container that cannot see the GPU, so the extra question can cost a turn there.

a runner, and the exit codes this skill documents are guesses, and a guess
presented as a fact is the failure this check prevents.

1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After asking which GPU, say what happens on each answer: NVIDIA/Intel/Apple declines per the gate, and AMD (e.g. the GPU is hidden by the very failure being diagnosed) should continue to rocm diagnose. As written the flow stops with no exit.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74. After the question, step 1 now says what each answer does: AMD (or "cannot say") continues with rocm diagnose, and NVIDIA, Intel or Apple is declined by the scope gate. The text names a container without GPU passthrough and the failure itself as ways the GPU can be hidden.

**print-only** (bootloader, kernel, reinstall, Windows driver, …): `rocm fix
<id>` just prints the plan for the user to run themselves — no prompt, and the
CLI never performs those.
CLI never performs those. In a diagnosis, `fix.auto_applicable` is true only

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalog marks fix-2-unset-override print-only on WSL as well as Linux (print-only on linux/wsl, auto on windows), so auto_applicable is false there too. Say "on Linux and WSL".

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74: "on Linux and WSL2", in the auto_applicable sentence and in the step 3 fix-2 bullet.

@volen-silo
volen-silo removed this pull request from the merge queue due to a manual request Nov 9, 2026
@jussielo-amd
jussielo-amd self-requested a review November 9, 2026 11:15

@jussielo-amd jussielo-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This was a static review of the head commit; I did not run the tests or the evals, and CI on this commit is green.

The description holds up against the diff and the CLI source: the examine status values, auto_applicable being true only for FixClass::Auto, the gate wording, and the untouched reference.md lines that skill_reference parses. I found no blocking problems. Small, non-blocking points besides the inline ones:

  • Non-blocking: the Workflow intro (~line 75, unchanged so I can't anchor it) still says "Only start here once the Scope gate passes — the GPU is AMD", which a literal reading takes to stop an unnamed vendor. Suggest "…the GPU is AMD or no vendor was named."
  • Non-blocking: step 0 can still offer the CLI install before examine can report no-amd-gpu, and line 40 ("Do not run rocm examine") now sits against step 1; worth a line in the description as deferred.
  • Non-blocking: reference.md still says "auto-applicable" in a few places, so "not fully gone" is true only for SKILL.md; fine as a follow-up since reference.md is deliberately untouched.
  • Non-blocking: no eval grades the new examine path (the description says so).

🤖 by agenthub on AMD AgentHub

Comment thread skills/rocm-doctor/SKILL.md Outdated

1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json`
first. Status `no-amd-gpu` means the CLI found no AMD GPU: say so, ask which
GPU the machine has, and propose no fix until that is settled. That status

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: after asking which GPU, the step says what happens for NVIDIA/Intel/Apple (the gate declines) but not for "AMD", for example a container without GPU passthrough, where no-amd-gpu is plausible. "Propose no fix until that is settled" leaves the next step open. Suggest one clause: "If the user confirms AMD, or cannot say, continue to rocm diagnose (it is read-only)."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74, with your wording: "If the user confirms AMD or cannot say, continue with rocm diagnose below, which only reads."

Comment thread skills/rocm-doctor/SKILL.md Outdated
CLI never performs those.
CLI never performs those. In a diagnosis, `fix.auto_applicable` is true only
for a fix whose `fix.class` is auto on this host, so it is false for
`fix-9-igpu-dgpu` and for `fix-2-unset-override` on Linux.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: fix-2-unset-override is print-only on WSL as well as Linux (PRINT_ON_LINUX_AND_WSL_AUTO_ON_WINDOWS in crates/rocm-core/src/fix/catalog.rs), so auto_applicable is false there too, and "on Linux" alone could read as true on WSL. Suggest "on Linux and WSL2" or "anywhere but Windows".

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74: "on Linux and WSL2" in both places.

Comment thread skills/rocm-doctor/SKILL.md Outdated
1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json`
first. Status `no-amd-gpu` means the CLI found no AMD GPU: say so, ask which
GPU the machine has, and propose no fix until that is settled. That status
alone does not prove the GPU is not AMD. Any other status: go on.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: on WSL2 rocm examine cannot report no-amd-gpu: compute_status in crates/rocm-core/src/examine.rs answers wsl before it checks for a GPU. So a WSL2 user who names no vendor and has, say, an NVIDIA GPU gets "Any other status: go on" and is never asked which GPU. unsupported-os also falls under "go on". Consider a line noting that on wsl the GPU evidence in the output decides, or call it a known limit in the description.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43f1c74. Checked in examine.rs: compute_status answers wsl before it asks about a GPU, and adopt_wsl_host_gpu sets has_amd_gpu from the Windows-side detection. Step 1 now reads has_amd_gpu on WSL2, and false there means the same as no-amd-gpu. unsupported-os and step 0 offering the install before examine can report anything are left as they were, and are listed under Deferred in the description.

@volen-silo
volen-silo force-pushed the fix/doctor-skill-review-followup branch from 788b875 to 43f1c74 Compare November 9, 2026 11:52
@volen-silo

Copy link
Copy Markdown
Collaborator Author

Pushed 43f1c74, folded into the single commit, with these changes from the reviews: Workflow intro now "AMD or no vendor was named"; step 1 has an exit for each answer to the which-GPU question (AMD or "cannot say" continues with rocm diagnose); step 1 reads has_amd_gpu on WSL2, where the status is always wsl; fix-2 is described as print-only on Linux and WSL2.

Not changed, and listed under Deferred in the description: reference.md still says "auto-applicable" in places (it is the e2e fixture, untouched here); step 0 can still offer the install before examine runs; unsupported-os falls under "any other result: go on"; no eval grades the examine path yet.

On the final text, in WSL2 with skillscope v0.1.3 on opus: behavioural 10/10 cases and 39/39 expectations, and routing 12/12. Requesting another look from juhovainio.

@volen-silo
volen-silo requested a review from juhovainio November 9, 2026 11:53

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking here: the WSL2 has_amd_gpu rule and the Linux/WSL2 print-only claim for fix-2-unset-override both match the code, and the two e2e fixture sentences are untouched. Requesting changes for the items below, which I'd like addressed or explicitly deferred before merge.

  1. The new examine branch in step 1 is not graded by any eval, because the recorded CLI refuses examine. The "10/10" evidence is a one-off local run, so the regression this PR fixes can return unnoticed. A follow-up that teaches evals/hooks.py to answer examine --json (no-amd-gpu, wsl with has_amd_gpu=false, ok) and adds eval items would close it.
  2. "Any other result: go on." also covers a failed or unparseable rocm examine --json. Step 0 says to relay the error and stop for a CLI error; step 1 should say the same.
  3. The scope gate still says "treat ROCm / HIP wording as AMD and continue", while step 1 then asks which GPU. The two read in tension.
  4. Nit: the "n/a" checklist boxes in the PR body are left unchecked.

Please also confirm there is a follow-up for the deferred reference.md "auto-applicable" wording.

Comment thread skills/rocm-doctor/SKILL.md Outdated
status alone does not prove the GPU is not AMD.

Only continue past this gate when the GPU is AMD.
If the user names no GPU vendor, treat ROCm / HIP wording as AMD and continue;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: "treat ROCm / HIP wording as AMD and continue" sits next to step 1, which then asks which GPU. Consider "continue to step 1, which checks the host" so the two do not read as in tension.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a1a81ee: the scope gate now says "treat ROCm / HIP wording as AMD and continue to step 1, which checks what the machine has."

Comment thread skills/rocm-doctor/SKILL.md Outdated
container without GPU passthrough, or the very failure being diagnosed, can
hide it. If the user confirms AMD or cannot say, continue with `rocm diagnose`
below, which only reads; if the answer is NVIDIA, Intel or Apple, the scope
gate declines. Any other result: go on.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Any other result: go on." also swallows a failed or unparseable rocm examine --json (examine exits 0 when it ran, so a non-zero exit is a CLI error). Suggest adding "if the command itself fails, relay the error and stop", as the contract check does.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a1a81ee. Step 1 now ends with: if rocm examine itself fails (it exits 0 whenever it ran, so a non-zero exit is an error from the CLI), relay the error text and stop, as the contract check does.

a runner, and the exit codes this skill documents are guesses, and a guess
presented as a fact is the failure this check prevents.

1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: this examine branch is not graded by any eval (the recorded CLI refuses examine), so the regression it fixes can come back unnoticed. Worth a follow-up to teach evals/hooks.py examine --json.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and not in this PR: the replay stub refuses examine, so grading it means teaching evals/hooks.py to answer examine --json from recordings and adding four evals (no-amd-gpu, wsl with has_amd_gpu false, ok, and examine failing). That is being filed as a follow-up ticket and I will link it here. Until then the branch is covered by scripted scenarios and local skillscope runs, as the description says.

Review of #909 found four things left over.

The rule that asks which GPU the machine has when rocm examine reports
no-amd-gpu had no step that ran examine, so a user who named no vendor on a
host without an AMD GPU still got has_match false and an upstream route. Step 1
now runs rocm examine --json first when no vendor is named.

The scope gate's closing line, "only continue when the GPU is AMD", could be
read as overriding the unnamed-vendor rule, and nothing brought the decline
back when the user then named another vendor. It now continues for an AMD or an
unnamed vendor and declines for NVIDIA, Intel or Apple.

"The auto-applicable set" was still in the contract-check paragraph, and step 1
showed the auto_applicable flag while step 3 said "has a runner". The paragraph
now says which fixes have a runner, and step 3 says what the flag means: true
only where the fix class is auto on this host.

The closing pointer to reference.md lost "the full closed catalog", and the skill
card's Description had become a run-on that dropped "print-only" for the two
vLLM failures. Both are restored.

Review then added three more.

The Workflow intro still said the GPU is AMD, which stopped an unnamed vendor
there too; it now says AMD or no vendor was named.

After asking which GPU, the flow had no exit for an answer of AMD, or for a user
who cannot say, such as a container without GPU passthrough. It now continues
with rocm diagnose, which only reads.

On WSL2 examine reports status wsl whatever the GPU, so step 1 reads
has_amd_gpu there. fix-2 is print-only on WSL2 as well as Linux, so the notes
say Linux and WSL2.

A second review pass found two more.

A failed rocm examine fell under "any other result: go on". examine exits 0
whenever it ran, so a non-zero exit is an error from the CLI; step 1 now relays
the error and stops, as the contract check does.

The scope gate's "treat ROCm / HIP wording as AMD and continue" read as in
tension with step 1, which then asks which GPU. It now says to continue to step
1, which checks the host.

Signed-off-by: Eugene Volen <eugene.volen@amd.com>
@volen-silo
volen-silo force-pushed the fix/doctor-skill-review-followup branch from 43f1c74 to a1a81ee Compare November 9, 2026 13:19
@volen-silo

Copy link
Copy Markdown
Collaborator Author

Pushed a1a81ee, folded into the single commit: a failed rocm examine now relays the error and stops, and the scope gate points at step 1 instead of "continue". The n/a boxes in the description are checked. The two deferrals (grading the examine path, and the reference.md "auto-applicable" wording) are being filed as follow-up tickets; I will link them here.

On this text in WSL2 with skillscope v0.1.3 on opus: behavioural 10/10 cases and 39/39 expectations, the two cases around step 1 passing in both extra runs, and routing 12/12. Requesting another look from juhovainio.

@volen-silo
volen-silo requested a review from juhovainio November 9, 2026 13:20

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The change does what the description says, and I found nothing blocking. I checked the examine status values and the WSL has_amd_gpu handling against crates/rocm-core/src/examine.rs. The e2e fixture sentences (contract_version, the print-only count) and reference.md are untouched.

Non-blocking notes (two inline):

  • The AMD / unnamed-vendor / decline rule is now stated in three places (scope gate, workflow intro, step 1). That is a drift risk worth keeping in mind.
  • No eval exercises the new rocm examine path. You flag that in the description, so I am only noting it.
  • reference.md still says "auto-applicable". The description defers this, so please make sure the follow-up ticket gets linked.

container without GPU passthrough, or the very failure being diagnosed, can
hide it. If the user confirms AMD or cannot say, continue with `rocm diagnose`
below, which only reads; if the answer is NVIDIA, Intel or Apple, the scope
gate declines. Any other result: go on. If `rocm examine` itself fails (it

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Any other result: go on" also covers degraded, which can hide the GPU the same way a container without passthrough does (and the deferred unsupported-os). Consider naming degraded here.

status alone does not prove the GPU is not AMD.

Only continue past this gate when the GPU is AMD.
If the user names no GPU vendor, treat ROCm / HIP wording as AMD and continue to

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 0 (CLI install) runs before the step 1 examine check this points at. Consider noting the ordering here, or the deferral.

@volen-silo
volen-silo enabled auto-merge November 9, 2026 13:27
@volen-silo
volen-silo added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit b48c4ae Nov 9, 2026
37 checks passed
@volen-silo
volen-silo deleted the fix/doctor-skill-review-followup branch November 9, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants