Repository navigation
fix(skill): run examine for an unnamed vendor and finish the vocabulary #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,12 +45,10 @@ advice for a stack this skill does not cover is worse than no advice. | |
| A fresh install on a clean machine is out of scope too: that is a setup task, | ||
| not a diagnosis. Exit cleanly and say so. | ||
|
|
||
| If the user names no GPU vendor, treat ROCm / HIP wording as AMD and continue. | ||
| Should `rocm examine` then report `no-amd-gpu`, the CLI found no AMD GPU: say so, | ||
| ask which GPU the machine has, and propose no fix until that is settled. That | ||
| status alone does not prove the GPU is not AMD. | ||
|
|
||
| Only continue past this gate when the GPU is AMD. | ||
| If the user names no GPU vendor, treat ROCm / HIP wording as AMD and continue to | ||
| step 1, which checks what the machine has. Continue when the GPU is AMD or no | ||
| vendor is named. If the user then says it is NVIDIA, Intel or Apple, decline as | ||
| above. | ||
|
|
||
| **WSL2 is in scope** and does not stop this gate. It is a platform family of its | ||
| own, with its own catalog entries covering `/dev/dxg`, the DXCore handoff, | ||
|
|
@@ -76,7 +74,7 @@ offered there. | |
| ## Workflow | ||
|
|
||
| Only start here once the [Scope gate](#scope-gate--check-before-anything-else) | ||
| passes — the GPU is AMD. | ||
| passes — the GPU is AMD or no vendor was named. | ||
|
|
||
| 0. **Ensure the `rocm` CLI is present.** Everything below shells out to it, so | ||
| check first and install it if missing: | ||
|
|
@@ -134,11 +132,23 @@ passes — the GPU is AMD. | |
| Any other failure, such as a different exit code or output with no | ||
| `contract_version`, is an error from the CLI and not proof that it is old. | ||
| Relay the error text and stop, because reinstalling the same version would not | ||
| clear it. Against a CLI without this contract, the entry ids, the | ||
| auto-applicable set, and the exit codes this skill documents are guesses, and a | ||
| guess presented as a fact is the failure this check prevents. | ||
|
|
||
| 1. **Diagnose.** Pass the user's error text as the symptom: | ||
| clear it. Against a CLI without this contract, the entry ids, which fixes have | ||
| a runner, and the exit codes this skill documents are guesses, and a guess | ||
| presented as a fact is the failure this check prevents. | ||
|
|
||
| 1. **Diagnose.** If the user named no GPU vendor, run `rocm examine --json` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After asking which GPU, say what happens on each answer: NVIDIA/Intel/Apple declines per the gate, and AMD (e.g. the GPU is hidden by the very failure being diagnosed) should continue to
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 43f1c74. After the question, step 1 now says what each answer does: AMD (or "cannot say") continues with
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking: this examine branch is not graded by any eval (the recorded CLI refuses
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, and not in this PR: the replay stub refuses |
||
| first. Status `no-amd-gpu` means the CLI found no AMD GPU. On WSL2 the status | ||
| is `wsl` whatever the GPU, so read `has_amd_gpu` there: false means the same. | ||
| Either way, say so, ask which GPU the machine has, and propose no fix until | ||
| that is settled. That result alone does not prove the GPU is not AMD: a | ||
| container without GPU passthrough, or the very failure being diagnosed, can | ||
| hide it. If the user confirms AMD or cannot say, continue with `rocm diagnose` | ||
| below, which only reads; if the answer is NVIDIA, Intel or Apple, the scope | ||
| gate declines. Any other result: go on. If `rocm examine` itself fails (it | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Any other result: go on" also covers |
||
| exits 0 whenever it ran, so a non-zero exit is an error from the CLI), relay | ||
| the error text and stop, as the contract check does. | ||
|
|
||
| Pass the user's error text as the symptom: | ||
|
|
||
| ``` | ||
| rocm diagnose --symptom "<paste the exact error>" --json | ||
|
|
@@ -228,19 +238,21 @@ passes — the GPU is AMD. | |
| Only four fixes have a runner the CLI executes itself. The other 24 are | ||
| **print-only** (bootloader, kernel, reinstall, Windows driver, …): `rocm fix | ||
| <id>` just prints the plan for the user to run themselves — no prompt, and the | ||
| CLI never performs those. | ||
| CLI never performs those. In a diagnosis, `fix.auto_applicable` is true only | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking:
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 43f1c74. The
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The catalog marks
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 43f1c74: "on Linux and WSL2", in the |
||
| for a fix whose `fix.class` is auto on this host, so it is false for | ||
| `fix-9-igpu-dgpu` and for `fix-2-unset-override` on Linux and WSL2. | ||
|
|
||
| One entry is in neither group. `info-20-gpu-no-rocm-support` is | ||
| **diagnose-only**: `rocm fix` takes the id, names the problem, says there is | ||
| no reliable fix, and exits 0 having changed nothing. | ||
|
|
||
| Of the four, two do not always mutate: | ||
|
|
||
| - **`fix-2-unset-override` mutates on Windows only.** On Linux it reports | ||
| where the override is set and which rc files carry it, then stops — it | ||
| will not edit the user's dotfiles. So there is no prompt to answer and | ||
| nothing for `--dry-run` to preview. Tell the Linux user what to edit; do | ||
| not describe it as a change the CLI made or previewed. | ||
| - **`fix-2-unset-override` mutates on Windows only.** On Linux and WSL2 it | ||
| reports where the override is set and which rc files carry it, then stops | ||
| — it will not edit the user's dotfiles. So there is no prompt to answer and | ||
| nothing for `--dry-run` to preview. Tell the user what to edit; do not | ||
| describe it as a change the CLI made or previewed. | ||
| - **`fix-9-igpu-dgpu` mutates only when `--device-index N` is passed.** | ||
| Without it — on either platform — the runner just prints the | ||
| `rocminfo`/`hipInfo` query that identifies the discrete GPU's index and | ||
|
|
@@ -308,5 +320,5 @@ start of the reply, before relaying a multi-step plan. | |
| first. New failure modes are added to the CLI catalog, not improvised here. | ||
|
|
||
| Read [reference.md](reference.md) when `rocm fix` exits non-zero (its exit codes | ||
| are listed there), and before telling the user which platforms a fix id applies | ||
| to. | ||
| are listed there), before telling the user which platforms a fix id applies to, | ||
| and for the full closed catalog. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 0 (CLI install) runs before the step 1 examine check this points at. Consider noting the ordering here, or the deferral.