019fff50 - Confirm adding a wallet address to the account - #25
Conversation
Customers confirm an account merge on realunit.app instead of being sent to the DFX services frontend. The page calls the public mail-confirm API and hands back to the app.
The first job status request no longer waits a second, so a one-second budget still completes. Job fetches use the same 15s abort as confirm.
A failed job GET no longer looks like an in-flight merge, and a confirm that still returns a job after Complete is treated as unavailable.
Baselines come from the Screenshots workflow runner so they match CI.
|
EN: DE: DetailsReview rounds: first pass found a missing English already-completed view, delayed first job poll, and missing job-fetch abort. Second pass found non-2xx job polling and a confirm/poll loop after Complete. Third Grok pass and Codex (quality + logic) reported 0 findings. Comments: none open. |
The confirmation page now says a wallet address is being added to the existing account.
TaprootFreak
changed the title
|
EN: DE: DetailsReview rounds: first pass found stale merge-* screenshot baselines after the add-address copy change, and a 202 job ticket that was already terminal still polling GET /v1/job. Second pass reported 0 findings after the terminal-ticket early-exit, two new Playwright cases, and Linux baseline refresh. Comments: one earlier ready comment on a superseded head (a643e2f); no open review threads. |
…920) EN: The handbook production deploy failed because the web-baseline guard still expected 22 Playwright PNGs after RealUnitCH/web added 14 for `/account-merge/`. This change raises `EXPECTED_WEB_BASELINE_COUNT` to 36 and adds matching cards in `#spec-web`. The cards describe adding a wallet address, not merging two accounts. After this lands on staging, the staging-to-develop promotion can run that deploy again. DE: Der Handbook-Produktions-Deploy ist fehlgeschlagen, weil der Web-Baseline-Guard noch 22 Playwright-PNGs erwartet hat, nachdem RealUnitCH/web 14 für `/account-merge/` ergänzt hat. Diese Änderung setzt `EXPECTED_WEB_BASELINE_COUNT` auf 36 und ergänzt die passenden Karten in `#spec-web`. Die Karten beschreiben das Hinzufügen einer Wallet-Adresse, nicht das Zusammenführen zweier Konten. Sobald das auf staging liegt, kann der Promote staging→develop den Deploy erneut fahren. <details> <summary>Details</summary> The auto-promotion PR #904 (`Promote: staging -> develop`) is red on `deploy-prd / Build and deploy to PRD` only: ``` Expected exactly 22 web baseline PNGs in _web-checkout/tests/__screenshots__, got 36. ``` Analyze & Test, Visual Regression, Coverage Floor Gate, and the PR-only Handbook Build Check stayed green: that last job does not clone RealUnitCH/web, so it never sees the count. Cause: RealUnitCH/web#25 committed 14 new Playwright baselines for `/account-merge/` (add a wallet address to an existing account). The previous handbook update of this guard was #862 (18 → 22, no-registration confirm states). There was no open PR covering 22 → 36. New files (14): | Viewport | Files | |---|---| | desktop-chromium | merge-confirmed(.png + -en.png), merge-invalid(.png + -en.png), merge-already-completed(.png + -en.png), merge-unavailable(.png + -en.png) | | tablet-chromium | merge-confirmed.png, merge-invalid.png (no tablet shots exist for already-completed / unavailable) | | mobile-safari | merge-confirmed-mobile.png, merge-invalid.png, merge-already-completed.png, merge-unavailable.png | Same markup as the existing confirm cards in `#spec-web`. Intro and `docs/handbook/README.md` now name `/account-merge/` next to `/confirm-aktionariat`. No Dart, no golden regeneration, no other workflow files. </details>
1 participant
EN:
Adds
/account-merge/so the confirmation link stays on realunit.app.The page says a wallet address is being added to the existing account.
It never talks about merging two accounts.
DE:
Neue Seite
/account-merge/, damit der Bestätigungslink auf realunit.app bleibt.Die Seite sagt, dass eine Wallet-Adresse dem bestehenden Konto hinzugefügt wird.
Sie spricht nicht von zwei Konten, die zusammengelegt werden.
Details
States: loading, confirmed, already-completed, invalid, unavailable. Mobile CTA
realunit-wallet://open. A 202 job ticket that is already terminal does not pollGET /v1/job/:uid. Linux visual baselines match the add-address copy.