Repository navigation
chore(deps): update typescript dependencies - #2411
Merged
Merged
Conversation
|
😎 This pull request was merged. |
Contributor
Author
|
Review at head 21ec720: high 0, medium 1, low 1. Medium (virtual-core 3.19.5 scrollToEnd clamp fix) filed as RIG-5782; low (stale bunfig.toml comment) filed as RIG-5783. Both are owned follow-ups linked in the body, under the merge-ASAP rule. |
1 task
|
Compass engineering docs preview: https://compass-native-2342-ts-deps.compass-eng-docs.pages.dev Deployed from |
Rebuilds Renovate #2342 on current main: ref-gate 1.0.1 and the virtual-core 3.19.3 override, with bun.lock and the compass-ui FOD hash regenerated from a real install and build. Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-native/2342-ts-deps
branch
from
October 18, 2026 20:17
21ec720 to
94961f2
Compare
Contributor
Author
|
Review at head 94961f2 (rebased onto main 50ce22b; main's length-gate bump kept; bun.lock and both FOD hashes regenerated, not hand-merged; diff identical to 21ec720): high 0, medium 1, low 1. Medium filed as RIG-5782, low as RIG-5783. Local: moon compass-ui/compass-client/root/ref-gates ci 23 tasks pass. |
rigel-mintaka
marked this pull request as ready for review
October 18, 2026 20:45
This was referenced Oct 18, 2026
rigel-mintaka
added this pull request to stack #2446
October 18, 2026 21:08
mattwilkinsonn
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainSummary
Rebuilds Renovate #2342 (TypeScript dependencies) on current main, because the Renovate branch conflicts.
@rigelbuild/ref-gate1.0.0 → 1.0.1 (catalog).@tanstack/virtual-coreoverride 3.19.0 → 3.19.3.bun.lockregenerated withbun install, not merged by hand. It also drops a stale server-imagebinentry whose workspace manifest declares no bin.apps/ui/dist.nixoutputHashrefreshed bytools/renovate/refresh-fod-hashes.ts, which runs a real nix build.The
agent-image/entrypoint.nixhashes are already on main. The refresher recomputed the same values, so that file is not in this diff. This PR does not carry #2342'srenovate.ymlCLI pin bump (44.155.7 → 44.155.8); that lands in #2435.Supersedes #2342.
Verification
refresh-fod-hashes.tsrealised both FODs and wrote back only the UI hash.nix build .#compass-uipasses with the new hash.moon run compass-ui:ci compass-client:ci root:ci ref-gates:cipasses (23 tasks, none cached).Risks
virtual-core 3.19.1–3.19.3 changes scroll correction (touchcancel handling, scrollToIndex reconcile). Upstream calls these bug fixes. The message surface uses it through
@rigelbuild/solid-virtual.Review follow-ups, not blocking:
scrollToEndbeing cancelled by a transient scroll clamp; bump separately.bunfig.tomlcomment still states the 3.17.8 override.Compatibility
No API change. The dev UI and agent image pick up the new lock.
Documentation
None needed.
Ledger-impact: none (dependency bump)