Repository navigation
fix(renovate): give the Renovate self-pin its own PR (RIG-5809) - #2443
Merged
Merged
Conversation
The self-pin bump moved only the workflow pin inside the TypeScript rollup, so the Reviewable cut test red every unrelated TS bump until a hand cut-over landed (#2397, #2407, #2435). Un-group it so the bump opens its own PR, where the REVIEWABLE_CUT_VERIFIED_AT edit goes. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 This pull request was merged. |
Contributor
Author
|
Review (reviewer agent) at head cf80d01: all clear, 0 findings. The rule matches only the custom.regex dep |
|
Compass engineering docs preview: https://dependencies-rig-5809-renova.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 18, 2026 21:10
mattwilkinsonn
deleted the
dependencies/rig-5809-renovate-selfpin-solo
branch
October 18, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RIG-5809. The Renovate self-pin (
bunx renovate@<v>in.github/workflows/renovate.yml) is acustom.regexdep, so the "TypeScript dependencies" rule grouped it into the TS rollup. That rollup moves only the workflow pin. The Reviewable cut test (pin equalsREVIEWABLE_CUT_VERIFIED_AT) then fails, and the whole TS rollup stays red until someone lands a hand cut-over. That happened three times on 10-18: #2397, #2407 and #2435.This adds a
groupName: nullrule fordepName: renovateundercustom.regex. The bump then opens its own PR, where the constant edit and thepr-body.jsre-check go. Unrelated TS bumps no longer go red.Verification
Received: "TypeScript dependencies"), then passed with the fix.bun test tools/renovate/gives 299 pass / 0 fail.moon run renovate:typecheckpasses and biome is clean.Risks
Low. The renovate self-pin PR still goes red until its constant is hand-edited; that red is intended and now isolated to that PR.
Compatibility
No other dependency changes group.
Documentation
None.