Skip to content

fix(renovate): give the Renovate self-pin its own PR (RIG-5809) #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwilkinsonn merged 1 commit into from
Oct 18, 2026
Merged

fix(renovate): give the Renovate self-pin its own PR (RIG-5809) #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tools/renovate/config.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,13 @@
matchFileNames: ["tools/toolchain/versions/*.nix"],
groupName: null,
},
{
// Renovate self-pin: a bump also needs a hand-verified
// REVIEWABLE_CUT_VERIFIED_AT edit, so keep it out of the TS rollup.
matchManagers: ["custom.regex"],
matchDepNames: ["renovate"],
groupName: null,
},
{
// ── First-party toolchain age-gate exemption ──
// The repo-wide `minimumReleaseAge: "5 days"` + `internalChecksFilter:
Expand Down
11 changes: 11 additions & 0 deletions tools/renovate/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,6 +1673,17 @@ describe("tools/renovate self-pin workflow (exact Renovate version)", () => {
const match = /bunx renovate@(?<version>\S+)/.exec(runLines);
expect(match?.groups?.version).toBe(REVIEWABLE_CUT_VERIFIED_AT);
});
// A self-pin bump needs a matching REVIEWABLE_CUT_VERIFIED_AT edit, so it must
// not ride the TS rollup, where it would red every unrelated bump.
test("a self-pin patch bump un-groups (null), not the TS rollup", () => {
const group = resolveGroupName({
manager: "custom.regex",
fileName: ".github/workflows/renovate.yml",
depName: "renovate",
updateType: "patch",
});
expect(group).toBeNull();
});

// The preflight uses GH_TOKEN to probe the repo and RENOVATE_TOKEN for its
// token-presence guard. Both env vars must be set or the workflow fails before
Expand Down
Loading