Skip to content

Make log_on_drop more convienient to disable - #926

Open
FireDasher wants to merge 2 commits into
RustAudio:masterfrom
FireDasher:master
Open

FireDasher wants to merge 2 commits into
RustAudio:masterfrom
FireDasher:master

Conversation

@FireDasher

@FireDasher FireDasher commented Sep 21, 2026

Copy link
Copy Markdown

All programs will end eventually, so I think it's beneficial to be able to disable log_on_drop without making your stream mutable.

Before:

let mut handle = rodio::DeviceSinkBuilder::open_default_sink().unwrap();
handle.log_on_drop(false);

After:

let handle = rodio::DeviceSinkBuilder::open_default_sink().unwrap().disable_log_on_drop();

(The old method still works for backwards compatibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant