Skip to content

Make log_on_drop more convienient to disable #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FireDasher wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

Make log_on_drop more convienient to disable #926

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2764f
Make log_on_drop more convienient to disable
FireDasher Sep 21, 2026
c55a3e0
Fix backwards compatibility
FireDasher Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,16 @@ impl MixerDeviceSink {

/// When [`MixerDeviceSink`] is dropped a message is logged to stderr or
/// emitted through tracing if the tracing feature is enabled.
/// Deprecated: Use disable_log_on_drop() instead
pub fn log_on_drop(&mut self, enabled: bool) {
self.log_on_drop = enabled;
}
/// When [`MixerDeviceSink`] is dropped a message is logged to stderr or
/// emitted through tracing if the tracing feature is enabled.
pub fn disable_log_on_drop(mut self) -> Self {
self.log_on_drop = false;
self
}
}

impl Drop for MixerDeviceSink {
Expand Down
Loading