Skip to content

🔒 Fix missing FileSystem capability check in CanvasOp::Save - #77

Merged
Tcode-Motion merged 1 commit into
mainfrom
security/fix-canvas-save-capability-5075834056834474534
Sep 8, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
security/fix-canvas-save-capability-5075834056834474534

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Fixed a security vulnerability in the CanvasOp::Save operation where canvas files could be saved to the filesystem without verifying if the executing script had the FileSystem capability granted.
⚠️ Risk: Without this check, a malicious script running in a sandboxed environment without file system permissions could bypass the sandbox and write arbitrary files (like SVG canvas outputs) to the host filesystem.
🛡️ Solution: Added a check using ctx.config.capabilities.contains(&Capability::FileSystem) in the CanvasOp::Save match arm in stdlib/src/canvas.rs before calling std::fs::write(). It returns a RuntimeErrorKind::InvalidOperation error if the capability is missing. Also added Capability::FileSystem to the required_capabilities list in the std.canvas module registry.


PR created automatically by Jules for task 5075834056834474534 started by @Tcode-Motion

Added `Capability::FileSystem` check in `stdlib/src/canvas.rs` before saving a canvas to the filesystem. Updated the module registry to declare the required capability.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:00
@Tcode-Motion
Tcode-Motion merged commit c8212a0 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant