Skip to content

🔒 Fix missing FileSystem capability check in CanvasOp::Save #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Sep 8, 2026
Merged

🔒 Fix missing FileSystem capability check in CanvasOp::Save #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions stdlib/src/canvas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;
use techscript_runtime::{
context::RuntimeContext, error::RuntimeError, function::Callable, value::RuntimeValue,
context::{Capability, RuntimeContext},
error::RuntimeError,
function::Callable,
value::RuntimeValue,
};

/// Convert a DslBlockValue to SVG string.
Expand Down Expand Up @@ -271,7 +274,7 @@ impl Callable for CanvasFn {
}
fn call(
&self,
_ctx: &mut RuntimeContext,
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
let mut buf = self.buffer.borrow_mut();
Expand Down Expand Up @@ -361,6 +364,15 @@ impl Callable for CanvasFn {
Ok(RuntimeValue::Null)
}
CanvasOp::Save => {
if !ctx.config.capabilities.contains(&Capability::FileSystem) {
return Err(RuntimeError::new(
techscript_runtime::error::RuntimeErrorKind::InvalidOperation(
"FileSystem capability is required to save canvas".to_string(),
),
None,
None,
));
}
let path = args[0].to_string();
let content = buf.clone();
std::fs::write(&path, &content).map_err(|e| {
Expand Down Expand Up @@ -659,7 +671,7 @@ impl StdlibRegistry {
name: "std.canvas".to_string(),
version: "1.0.0".to_string(),
exports,
required_capabilities: Vec::new(),
required_capabilities: vec![Capability::FileSystem],
},
);
}
Expand Down
Loading