Skip to content

🧹 Extract import lowering to reduce deep nesting in lower_statement - #89

Merged
Tcode-Motion merged 1 commit into
mainfrom
fix-lower-statement-nesting-10670054220632445716
Sep 8, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
fix-lower-statement-nesting-10670054220632445716

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Reduced deep nesting in the lower_statement method within compiler/ir/src/lowering.rs by extracting the Statement::Import match arm logic into a new dedicated lower_import method.

💡 Why: The lower_statement function was growing overly large and deeply nested, specifically around the Statement::Import handling which accounted for roughly 70 lines of complex control flow. Extracting this into a separate method improves readability, makes the lower_statement match block more consistent with other statement types (like lower_var_decl and lower_const_decl), and makes the codebase easier to maintain.

✅ Verification:

  • Ran targeted tests for the IR compiler (cargo test -p techscript_ir).
  • Ran the full workspace test suite (cargo test --workspace) to ensure no regressions were introduced elsewhere.
  • Ran formatting (cargo fmt --all).
  • Requested and passed code review.

✨ Result: The lower_statement method is now significantly shorter and easier to read, with the complex import lowering logic cleanly isolated in lower_import without changing any behavior.


PR created automatically by Jules for task 10670054220632445716 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:06
@Tcode-Motion
Tcode-Motion merged commit 64fd009 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant