Skip to content

🧹 Extract import lowering to reduce deep nesting in lower_statement #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcode-Motion merged 1 commit into from
Sep 8, 2026
Merged

🧹 Extract import lowering to reduce deep nesting in lower_statement #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 68 additions & 68 deletions compiler/ir/src/lowering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,74 +215,7 @@ impl LoweringContext {
self.lower_statement(&decl.declaration);
}
Statement::Import(import_stmt) => {
let path_str = import_stmt
.path
.iter()
.map(|ident| ident.name.clone())
.collect::<Vec<_>>()
.join("/");
self.builder.declare_import(path_str);

if let Some(symbols) = &import_stmt.symbols {
if import_stmt.path.len() > 1
&& symbols.len() == 1
&& !symbols[0].name.contains(':')
&& symbols[0].name != "*"
{
let alias_name = symbols[0].name.clone();
// For namespace alias, the global variable representing it is the root namespace of the path
let root_name = import_stmt.path[0].name.clone();
let global_id = self.builder.declare_global(root_name, IRType::Any);
self.symbol_map
.insert(alias_name, SymbolBinding::Global(global_id, IRType::Any));
} else {
for sym in symbols {
if sym.name == "*" {
let module_path = import_stmt
.path
.iter()
.map(|i| i.name.clone())
.collect::<Vec<_>>()
.join(".");
let registry = techscript_stdlib::StdlibRegistry::new();
if let Some(module) = registry.get_module(&module_path) {
for func_name in module.exports.keys() {
let global_id = self
.builder
.declare_global(func_name.clone(), IRType::Any);
self.symbol_map.insert(
func_name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
}
} else if sym.name.contains(':') {
let parts: Vec<&str> = sym.name.split(':').collect();
let orig_name = parts[0].to_string();
let alias_name = parts[1].to_string();
let global_id = self.builder.declare_global(orig_name, IRType::Any);
self.symbol_map.insert(
alias_name,
SymbolBinding::Global(global_id, IRType::Any),
);
} else {
let global_id =
self.builder.declare_global(sym.name.clone(), IRType::Any);
self.symbol_map.insert(
sym.name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
}
}
} else if !import_stmt.path.is_empty() {
let root_name = import_stmt.path[0].name.clone();
let global_id = self.builder.declare_global(root_name.clone(), IRType::Any);
self.symbol_map.insert(
root_name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
self.lower_import(import_stmt);
}
Statement::EnumDecl(decl) => {
// Declare enum type globally
Expand All @@ -305,6 +238,73 @@ impl LoweringContext {
}
}

fn lower_import(&mut self, import_stmt: &techscript_ast::ImportStmt) {
let path_str = import_stmt
.path
.iter()
.map(|ident| ident.name.clone())
.collect::<Vec<_>>()
.join("/");
self.builder.declare_import(path_str);

if let Some(symbols) = &import_stmt.symbols {
if import_stmt.path.len() > 1
&& symbols.len() == 1
&& !symbols[0].name.contains(':')
&& symbols[0].name != "*"
{
let alias_name = symbols[0].name.clone();
// For namespace alias, the global variable representing it is the root namespace of the path
let root_name = import_stmt.path[0].name.clone();
let global_id = self.builder.declare_global(root_name, IRType::Any);
self.symbol_map
.insert(alias_name, SymbolBinding::Global(global_id, IRType::Any));
} else {
for sym in symbols {
if sym.name == "*" {
let module_path = import_stmt
.path
.iter()
.map(|i| i.name.clone())
.collect::<Vec<_>>()
.join(".");
let registry = techscript_stdlib::StdlibRegistry::new();
if let Some(module) = registry.get_module(&module_path) {
for func_name in module.exports.keys() {
let global_id =
self.builder.declare_global(func_name.clone(), IRType::Any);
self.symbol_map.insert(
func_name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
}
} else if sym.name.contains(':') {
let parts: Vec<&str> = sym.name.split(':').collect();
let orig_name = parts[0].to_string();
let alias_name = parts[1].to_string();
let global_id = self.builder.declare_global(orig_name, IRType::Any);
self.symbol_map
.insert(alias_name, SymbolBinding::Global(global_id, IRType::Any));
} else {
let global_id = self.builder.declare_global(sym.name.clone(), IRType::Any);
self.symbol_map.insert(
sym.name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
}
}
} else if !import_stmt.path.is_empty() {
let root_name = import_stmt.path[0].name.clone();
let global_id = self.builder.declare_global(root_name.clone(), IRType::Any);
self.symbol_map.insert(
root_name.clone(),
SymbolBinding::Global(global_id, IRType::Any),
);
}
}

fn lower_var_decl(&mut self, decl: &VarDecl) {
let ty = self.map_type_spec(&decl.type_ann);
let init_val = self.lower_expression(&decl.initializer);
Expand Down
Loading