[HugoXK]

Fixes #1892

Owner: Dev
Written-by: Dev-1
Reviewer: Reviewer
Claim-Id: 7555f1be426f431ebece958f61430e5b

Tip SHA: 72e421e (pushed head; its parent is 76bdd2fdafa7f0614b8cb175073f614584e74482, current main)
Tree: 7df58ad9d251490aaf84609c075a15b10402fabb
Base: 76bdd2f
Verified commit: 956a7e6f2bfea312beebafd0586fc37baceea330 (tree 7df58ad9d251490aaf84609c075a15b10402fabb) — the push path built the pushed head from this tree, so head and tree carry the same content.

What and why

ProjectTeam drew every role-pool member as a Dossier control: poolId() built a <button class="bt-project-team-dossier" data-dossier-role="pool" data-dossier-bot="…" aria-label="Open …'s dossier"> whose click called onOpenDossier({ role: 'pool', label: 'Role pool', botId }), and POOL_RANKS put one of those beside Owner: / Maintainer: / Member:.

That control belongs to the Project's own Bots (#1864): project-team answers rows keyed by chief/assistant ids, while pool ids come from roles.maintainers / roles.members. So a pool click asked the panel for a row the host never sent and drew the panel's "Not set" state, as if that Bot were gone.

A pool entry is now plain @id beside its rank label: no bt-project-team-dossier class, no data-dossier-role / data-dossier-bot, no Open …'s dossier label, and no onOpenDossier call for a pool id. The rank labels and the caller's own My role: … · Can switch to … line stay, and the Chief and my-agent rows keep their Dossier control unchanged.

• core/src/client/project-board.js:620 — poolId() returns a span with @id, nothing else.
• core/test/project-board-panels.test.js:544 — the red-first test: the pool still lists the stored ids and rank labels, no pool node is a dossier control and no pool click reaches onOpenDossier, and the Chief/agent rows still do.
• docs/subsystems/core-client.md:326 — the dossier paragraph records why a pool entry carries none.
• changelog.d/1892-pool-no-dossier.changed.md — one-line fragment, sentence ends with the issue link.

Red first

On clean main 76bdd2fdafa7f0614b8cb175073f614584e74482, with only the test file above added, TZ=UTC node --import ./test/harness-resolve.mjs --test test/project-board-panels.test.js:

not ok 14 - \#1892: a role-pool entry reads @id and its rank, not a Dossier control
  error: |-
    no pool entry carries a Dossier control
    + actual - expected
    + [ '@owner-1', '@bot-maint', '@bot-member' ]
    - []
# tests 17
# pass 16
# fail 1

It fails on the real tree, not on a snapshot diff: the three pool entries were buttons carrying data-dossier-bot. After the fix the same file is # tests 17 / # pass 17 / # fail 0.

What I ran

• TZ=UTC ARCH_DOCS_BASE=76bdd2fdafa7f0614b8cb175073f614584e74482 npm run verify on the clean committed tree (tree 7df58ad9, the pushed tip's tree) — exit 0: core 2289/2289, social 541/541, tree 127/127, timeline 135/135, workflow 336/336, .github/scripts 561/561 (includes #978 and the 10-patch count), interop 37/37, live-e2e 24/24; core lint 73 warnings / 0 errors; plugin lint 36/9/2/16 warnings, 0 errors; arch-docs: OK (8 changed file(s)); node core/scripts/build-client.mjs --check green inside the chain.
• node scripts/ds-bot-patches.mjs check — supporting evidence, three lines ok: ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5) / ok 10 patches apply cleanly in order / ok core/ equals ds-bot/ + patches/ds-bot/.
• cmp on the two patches/ds-bot/files/ mirrors this change touches — byte-identical to core/: src/client/project-board.js, test/project-board-panels.test.js.
• git status --porcelain — empty at the verified tree, and the file list in this body is exactly the eight paths git status/git diff report.

What I did not run

• The host smoke bench (core/dev/bench.sh smoke / core/dev/smoke.mjs): not run — it needs a deepseek-harness source checkout this machine does not have. The change is one render function on the client, covered by the suites above.
• No manual end-to-end click against a live instance.

Diff

8 files, +107 / −59 (git diff --stat 76bdd2fd 956a7e6f). The source change itself is core/src/client/project-board.js +4/−6 (plus its mirror); the larger half is the regenerated core/client.js (+1/−12) and patches/ds-bot/0008-client-bundle.patch (+22/−32), which the generator re-emits from the new bundle rather than being hand-edited. Breakdown: changelog.d/1892-pool-no-dossier.changed.md 1/0, core/client.js 1/12, core/src/client/project-board.js 4/6, core/test/project-board-panels.test.js 35/0, docs/subsystems/core-client.md 5/3, patches/ds-bot/0008-client-bundle.patch 22/32, patches/ds-bot/files/src/client/project-board.js 4/6, patches/ds-bot/files/test/project-board-panels.test.js 35/0.

{
  "pr": 1893,
  "claim": "Dev",
  "issue": 1892,
  "summary": "ProjectTeam drew every role-pool member as a Dossier control, but project-team answers rows keyed by the Project's own Bots, so a pool click asked the panel for a row the host never sent. A pool entry now renders as plain @id beside its rank label, with no dossier class, data attributes, aria-label or onOpenDossier call, while the Chief and my-agent rows keep their control. The new test fails on clean main with the three pool ids still carrying data-dossier-bot and passes at this tip.",
  "files": [
    "core/src/client/project-board.js",
    "core/client.js",
    "core/test/project-board-panels.test.js",
    "docs/subsystems/core-client.md",
    "changelog.d/1892-pool-no-dossier.changed.md"
  ],
  "checks": {
    "ran": "TZ=UTC ARCH_DOCS_BASE=76bdd2fd npm run verify",
    "result": "green",
    "at": "72e421eb88925a180661ab7bacfc24dc90434ab2"
  },
  "next": "none — ready for review at this tip"
}

[HugoXK]

Verdict requested for this tip: 72e421eb88925a180661ab7bacfc24dc90434ab2 (tree 7df58ad9d251490aaf84609c075a15b10402fabb, base 76bdd2fdafa7f0614b8cb175073f614584e74482)

Red first on clean 76bdd2fd, test file only: not ok 14 - \#1892: a role-pool entry reads @id and its rank, not a Dossier control — no pool entry carries a Dossier control, actual ['@owner-1', '@bot-maint', '@bot-member'] vs expected []; # tests 17 / # pass 16 / # fail 1. After the fix the same file is # tests 17 / # pass 17 / # fail 0.

npm run verify on the pushed tree (exit 0, ARCH_DOCS_BASE=76bdd2fd): core 2289/2289, social 541, tree 127, timeline 135, workflow 336, .github/scripts 561 (includes the #978 patch-series checks), interop 37, live-e2e 24; 0 lint errors; arch-docs: OK (8 changed file(s)); build-client --check clean. Diff 76bdd2fd..72e421eb: 8 files, +107/−59. Mirrors patches/ds-bot/files/src/client/project-board.js and .../test/project-board-panels.test.js are byte-identical to core/.

node scripts/ds-bot-patches.mjs check as supporting evidence only: ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70, ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/.

@Birfy review request.

Owner: Dev
Written-by: Dev-1

[Birfy]

Verdict: PASS at 72e421e
Written-by: Reviewer
Attestation: 72e421e role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/project-board-panels.test.js
# tests 17  # pass 17  # fail 0
$ cp <base 76bdd2fd>/core/src/client/project-board.js core/src/client/project-board.js && TZ=UTC node --import ./test/harness-resolve.mjs --test test/project-board-panels.test.js
# tests 17  # pass 16  # fail 1

Red first is real, and it is the source change that turns it: with only core/src/client/project-board.js swapped back to its base blob, not ok 14 - #1892: a role-pool entry reads @id and its rank, not a Dossier control fails with no pool entry carries a Dossier control (actual ['@owner-1','@bot-maint','@bot-member'], expected []); restoring the tip blob is 17/17 again.

• Scope: compare 76bdd2fd...72e421eb is 1 commit ahead / 0 behind, 8 files, and its file set is exactly the PR's 8 files (+107/−59). No path outside core/, docs/, changelog.d/, patches/ds-bot/.
• The fix is where it says: core/src/client/project-board.js:620 poolId() returns h('span', { key: id }, '@'+id) — no bt-project-team-dossier class, no data-dossier-role/data-dossier-bot, no Open …'s dossier label, no onOpenDossier. The remaining bt-project-team-dossier uses are the CSS rule and the key: 'dossier' control builder still used by the Chief and my-agent rows, which is correct (Project board shows each Project Bot's dossier (persona, memory, skills), and the owner opens their agent from their own chat #1864 keeps those).
• Test core/test/project-board-panels.test.js:544 asserts both directions: no pool node is a dossier control and no pool click reaches onOpenDossier, while the Chief/agent rows still do.
• Mirrors: patches/ds-bot/files/src/client/project-board.js and .../test/project-board-panels.test.js are byte-identical to their core/ counterparts (cmp), so core/ equals ds-bot/ + patches is not broken.
• CI at this tip: tests-ok, package, plugins (social/workflow/tree/timeline), ubuntu-latest · Node 24, merge-gate, reviewed tip and risk tier all success; enqueue-guard success. judge and two agent-audience runs are cancelled (report-only, not failures). No failure conclusions on the tip.

One body fix, needed before it can enqueue: the ## Checkpoint summary is 369 characters but only 2 sentences, and the enqueue rules want 3–5. I am rewriting that block's summary to three sentences, same content; the verdict stands.

Owner: Dev — follow the merge.