Build release and CI on a runner of each labeled architecture - #20
Merged
Merged
Conversation
The release workflow's arch matrix never chose a runner, so each OS was built once and uploaded under both labels: the macOS "x64" asset was an ARM binary and the Ubuntu "arm64" asset was x86-64. Name a runner for each platform (ubuntu-24.04-arm, macos-15-intel) and keep os/arch for the asset names so the release table script still works. CI now builds and tests on the same four platforms. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archmatrix was never used to pick a runner, so each OS was built once and uploaded under both architecture labels. In RC5 the macOS "x64" asset is an arm64 binary and the Ubuntu "arm64" asset is an x86-64 binary (checked withfile).runnerto each matrix entry (ubuntu-latest,ubuntu-24.04-arm,macos-latest,macos-15-intel) so every asset is built on the architecture it is labeled with.osandarchstill name the asset, soupdate_release_table.pyis unaffected.Test plan
build-and-checkjobs passfileon the binaries🤖 Generated with Claude Code