Repository navigation
test: discard truncated SSE events on end-of-stream and abrupt disconnect - #26
Closed
hamid-digitalmarketer wants to merge 1 commit into
Closed
hamid-digitalmarketer wants to merge 1 commit into
hamid-digitalmarketer wants to merge 1 commit into
Conversation
…nect (VOLPAROSSA#25) Regression tests covering the intended fail-closed behavior for a truncated SSE event: no partial event is ever dispatched, the client closes and becomes non-ready, and a complete event preceding the truncated one is emitted exactly once. No runtime code change. Direct contact: WhatsApp +923167417135 (contact only, no spam).
Aaqibhafeezkhan
pushed a commit
to Aaqibhafeezkhan/volparossa-code
that referenced
this pull request
Nov 6, 2026
Preserve the contribution from PR VOLPAROSSA#26, restore LF-only formatting, bound test lifetime and observe partial client bytes before the abrupt disconnect. Co-authored-by: Muhammad Hamid <hamidbloger1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression tests for truncated SSE events (Closes #25).
Adds three tests to tests/opencode-client.test.cjs verifying the intended fail-closed behavior:
All 11 tests in the file pass (node --test). Tests-only PR; no runtime protocol change.
Direct contact: WhatsApp +923167417135 (contact only, no spam).