Repository navigation
Verify truncated SSE behavior with bounded, observable disconnect tests - #29
Merged
Merged
Conversation
Preserve the contribution from PR #26, restore LF-only formatting, bound test lifetime and observe partial client bytes before the abrupt disconnect. Co-authored-by: Muhammad Hamid <hamidbloger1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three truncated-event regressions contributed in #26, retaining the original author's attribution. Incomplete events are discarded at normal EOF and abrupt disconnect, and a prior complete event is emitted once. The abrupt-disconnect test first proves the partial bytes reached the client; each new test has a deadline. LF formatting avoids an unrelated whole-file rewrite.
Validation: all 11 tests in tests/opencode-client.test.cjs pass on Node 24.19; git diff --check passes; only 55 test lines added, with no runtime protocol change.
Supersedes #26 because the connected GitHub integration cannot push to its contributor fork (403), even though maintainer edits are enabled. The original discussion and commit remain preserved. Fixes #25.