Skip to content

fix(ci): run existing checks on dev pull requests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logbie wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(ci): run existing checks on dev pull requests #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aea8a1
fix(ci): run existing checks on dev pull requests
Paperclip-Paperclip Sep 27, 2026
466aa5a
test(ci): preserve dev PR coverage and align testing policy
Paperclip-Paperclip Sep 27, 2026
ba48484
fix(test): normalize Windows line endings in CI target assertions
Paperclip-Paperclip Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/governance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches: [main]
pull_request:
branches: [main]
branches: [main, dev]
Comment thread
logbie marked this conversation as resolved.
workflow_dispatch:

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wfl-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches: [main]
pull_request:
branches: [main]
branches: [main, dev]
workflow_dispatch:

permissions:
Expand Down
4 changes: 2 additions & 2 deletions testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ keyboard behavior, or data integrity.
checks on Blacksmith Linux and GitHub-hosted Windows.
[WFL tests](.github/workflows/wfl-tests.yml) runs the complete WFL suite via
`wfl --execution-timeout 1200 scripts/run_tests.wfl` on
`blacksmith-2vcpu-ubuntu-2404`. Both workflows run for pushes and pull requests to
`main` and support manual dispatch.
`blacksmith-2vcpu-ubuntu-2404`. Both workflows run for pushes to `main`, pull requests to `main` and `dev`,
and manual dispatch.

WFL tests pulls `bsbyrdwfl/wfl:nightly` from Docker Hub for every run, resolves
the image digest, and uses that immutable image for that run's runtime checks.
Expand Down
20 changes: 20 additions & 0 deletions tests/tooling/ci_targets.test.wfl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Keep dev PR coverage while preserving the main-only push boundary.
include from "../../scripts/test_support.wfl"

store repo_root as path_dirname of (path_dirname of script_directory)

describe "Governance rollout CI targets":
test "both workflows admit dev PRs without broadening push events":
for each workflow_name in ["governance.yml", "wfl-tests.yml"]:
store workflow_path as path_join of repo_root and ".github/workflows" and workflow_name
store raw_workflow as test_read_text of workflow_path
// Windows checkout uses CRLF; event semantics do not depend on EOL.
store workflow_text as ""
for each text_fragment in (split raw_workflow by "\r"):
change workflow_text to workflow_text with text_fragment
end for
expect workflow_text to contain " pull_request:\n branches: [main, dev]"
expect workflow_text to contain " push:\n branches: [main]\n"
end for
end test
end describe
Loading