Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bc00fef6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, dev ] |
There was a problem hiding this comment.
Adding dev here and to the config-lint workflow does not update .github/workflows/docker-image.yml, whose pull_request.branches remains [main]. Consequently, a PR into the newly mandated dev target that changes src/**, Cargo files, Docker scripts, or another listed runtime path can merge without the consumer-image static-link and smoke tests running on that revision. Add dev to the Docker Runtime Validation pull-request filter as well.
Useful? React with 👍 / 👎.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, dev ] |
There was a problem hiding this comment.
🟡 Docker runtime checks miss dev pull requests
For a dev pull request changing runtime sources, CI runs but Docker image validation does not. Docker Runtime Validation still selects only main pull requests, leaving image builds and consumer smoke tests unverified before merging.
Learn more
The Docker validation workflow is separate from the normal CI workflow. Its pull request trigger selects runtime and packaging paths but only targets main. Its validation job builds a musl-linked Docker image and runs a consumer smoke test. Routing ordinary contributions into dev while enabling only normal CI there leaves this affected suite absent until promotion.
Example: A PR into dev changes src/main.rs so the static musl build fails. Regular CI runs, but the Docker workflow never starts. The failure is first detected when the change is promoted toward main.
Recommended fix: Add dev to the Docker workflow's pull_request.branches while retaining its existing path filters. Check whether any other path-filtered required workflows must also follow the new PR target.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
|
||
| Follow [GOVERNANCE.md](../../GOVERNANCE.md) for feature → `dev` PRs, | ||
| Yomi review, exact-commit Actions evidence, bot feedback and promotion authority. | ||
| Use the [canonical PR checklist](../../.github/pull_request_template.md). |
There was a problem hiding this comment.
🔍 Competing pull request templates
The guide still presents an earlier PR template before linking the new checklist. Its generic testing fields omit the current SHA, individual Actions results, and Yomi review, leaving contributors with conflicting examples.
Was this helpful? React with 👍 or 👎 to provide feedback.
2 participants
Summary
Align contribution governance with Brad's approved LOG-10 policy and dev/CEO delegations, tracked by Paperclip LOG-19. Feature branches target dev; Yomi reviews the current revision and exact-commit CI remains required.
Changes
Compatibility and risk
Documentation change is R0. No language/runtime, palette, licensing or product behavior changes in this documentation commit.
This PR is stacked on unmerged CI PR 748, and targets dev. Review the documentation commit separately from that dependency; the full base diff still includes its independently reviewed CI work. Do not merge either past its review/control gates.
Independent GitHub approval identity is deferred: shared logbie cannot approve its own PR. Yomi review and protected-branch requirements remain binding. No bypass.
Validation
Documentation commit:
0bc00fef6e32790a5fd53ee908dccaec70d48d69.Behavior tests N/A — the new commit edits prose and PR guidance only; required Actions are not waived.
Local
git diff --check, changed-Markdown local-path checks and common-policy equality checks passed. Repository hygiene passed.External URLs and heading anchors were not network-validated. Actions on this new SHA are pending; no old-head pass is claimed.
Three pre-existing broken local security links were corrected to maintained documentation.
Checklist
The owner tracks pending Actions/bot feedback on Paperclip LOG-19 with a scheduled monitor. Main/release/tag/deploy decisions follow GOVERNANCE.md; this PR grants no merge permission.