-
Notifications
You must be signed in to change notification settings - Fork 0
docs: harmonize governance and contribution authority #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Summary | ||
|
|
||
| Describe the final change and owning issue. | ||
|
|
||
| ## Compatibility and risk | ||
|
|
||
| Risk class, affected contracts, exceptions and unresolved controls. | ||
|
|
||
| ## Validation | ||
|
|
||
| Current SHA, exact commands/results, Actions links, Red/Green or justified | ||
| documentation-only N/A. Record missing/skipped checks as Not run with reason. | ||
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] Feature/fix/docs branch targets `dev`; no direct protected-branch push. | ||
| - [ ] Current SHA, Actions run links and individual required results are recorded. | ||
| - [ ] Red/Green evidence, or justified documentation-only N/A with doc/link checks. | ||
| - [ ] Skipped, missing, pending and failed checks are explicit, never called passes. | ||
| - [ ] Yomi reviewed this revision; material fixes have fresh CI and review. | ||
| - [ ] Triggered bot reviews finished; findings/discussions are fixed or dispositioned. | ||
| - [ ] PR owner has a real monitor/event continuation while checks or reviews are pending. | ||
| - [ ] No secrets/private data; environment injection and production boundaries observed. | ||
| - [ ] No protection bypass; check/review state is rechecked immediately before merge. | ||
| - [ ] Main/release/tag/deploy authority and Brad-reserved decisions follow GOVERNANCE.md. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ on: | |
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, dev ] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Docker runtime checks miss dev pull requests For a Learn moreThe Docker validation workflow is separate from the normal CI workflow. Its pull request trigger selects runtime and packaging paths but only targets Example: A PR into Recommended fix: Add Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| # Without this, every push to a branch leaves the previous run compiling a | ||
| # commit whose result nobody will ever read. A superseded clippy-and-test run | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -270,3 +270,9 @@ You've completed the Best Practices section. You now know how to write quality W | |
| --- | ||
|
|
||
| **Previous:** [← Project Organization](project-organization.md) | **Next:** [Guides →](../guides/) | ||
|
|
||
| ## Repository contribution authority | ||
|
|
||
| Follow [GOVERNANCE.md](../../GOVERNANCE.md) for feature → `dev` PRs, | ||
| Yomi review, exact-commit Actions evidence, bot feedback and promotion authority. | ||
| Use the [canonical PR checklist](../../.github/pull_request_template.md). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Competing pull request templates The guide still presents an earlier PR template before linking the new checklist. Its generic testing fields omit the current SHA, individual Actions results, and Yomi review, leaving contributors with conflicting examples. Was this helpful? React with 👍 or 👎 to provide feedback. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
devhere and to the config-lint workflow does not update.github/workflows/docker-image.yml, whosepull_request.branchesremains[main]. Consequently, a PR into the newly mandateddevtarget that changessrc/**, Cargo files, Docker scripts, or another listed runtime path can merge without the consumer-image static-link and smoke tests running on that revision. Adddevto the Docker Runtime Validation pull-request filter as well.Useful? React with 👍 / 👎.