Skip to content

test(structural): cover call and containment topology - #72

Merged
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-22-call-containment-golden
Sep 29, 2026
Merged

nia-sg-bot merged 1 commit into
mainfrom
nia/issue-22-call-containment-golden

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • extend the staged Python topology golden fixture with a nested function and a local call
  • assert deterministic contains and calls edges alongside the existing add/modify/delete/rename/import coverage

Part of #22.

Validation

  • python3 -m pytest (203 passed)
  • git diff --check

Summary by CodeRabbit

  • Tests
    • Expanded coverage for Python code structure to verify that nested functions are represented as contained within their parent function and that calls between them are detected. This helps ensure structural analysis correctly captures relationships involving nested functions.

@nia-sg-bot nia-sg-bot added roadmap Tracked on the public WildestAI roadmap priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6fa8f077-3efb-48fe-ad03-136053f1b4e8

📥 Commits

Reviewing files that changed from the base of the PR and between aea6eee and 0a30010.

📒 Files selected for processing (2)
  • tests/fixtures/python_topology.json
  • tests/test_structural.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The added-file Python fixture now defines a nested child() function inside added(). The topology fixture records the child symbol and its calls and contains relationships. The structural test checks both relationships.

Changes

Nested function topology

Layer / File(s) Summary
Nested function fixture and assertions
tests/test_structural.py, tests/fixtures/python_topology.json
The fixture defines child() inside added(). The topology fixture adds the child function symbol and its calls and contains relationships. The test checks both relationships.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0a300

The added topology coverage introduces no identified merge-blocking risk; the PR is ready for normal checks and merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the structural test change and the added call and containment topology coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nia-sg-bot
nia-sg-bot merged commit 773e1d0 into main Sep 29, 2026
4 checks passed
@nia-sg-bot
nia-sg-bot deleted the nia/issue-22-call-containment-golden branch September 29, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction priority:P0 Critical path / blocks a usable product roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant