Skip to content

test(structural): cover call and containment topology #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nia-sg-bot merged 1 commit into from
Sep 29, 2026
Merged

test(structural): cover call and containment topology #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/fixtures/python_topology.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@
"kind": "function",
"change_kind": "added"
},
{
"id": "sym::add.py::added.child",
"kind": "function",
"change_kind": "added"
},
{
"id": "sym::add.py::import::external.pkg",
"kind": "import",
Expand Down Expand Up @@ -87,6 +92,14 @@
{
"id": "rel::file::renamed.py->sym::renamed.py::moved",
"kind": "defines"
},
{
"id": "rel::sym::add.py::added->sym::add.py::added.child",
"kind": "calls"
},
{
"id": "rel::sym::add.py::added->sym::add.py::added.child",
"kind": "contains"
}
]
}
6 changes: 5 additions & 1 deletion tests/test_structural.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_staged_add_modify_delete_rename_import_is_schema_valid_and_golden(tmp_p
write(root, "rename.py", "def moved():\n return 1\n")
commit(root)

write(root, "add.py", "import os\nfrom external.pkg import value\n\ndef added():\n return value\n")
write(root, "add.py", "import os\nfrom external.pkg import value\n\ndef added():\n def child():\n return value\n return child()\n")
write(root, "modify.py", "def retained():\n return 2\n\ndef created():\n return 3\n")
os.unlink(root / "delete.py")
git(root, "mv", "rename.py", "renamed.py")
Expand All @@ -92,6 +92,10 @@ def test_staged_add_modify_delete_rename_import_is_schema_valid_and_golden(tmp_p
assert [r["label"] for r in imports] == [
"unresolved/external module: external.pkg", "unresolved/external module: os"
]
assert {(r["kind"], r["source_id"], r["target_id"]) for r in artifact["relationships"] if r["kind"] in ("contains", "calls")} == {
("contains", "sym::add.py::added", "sym::add.py::added.child"),
("calls", "sym::add.py::added", "sym::add.py::added.child"),
}
for file_entry in artifact["files"]:
provenance = json.loads(file_entry["evidence"][0]["detail"])
assert provenance["old_oid"] is None or len(provenance["old_oid"]) == 40
Expand Down
Loading