Skip to content

Fix Linux pairing with isolated shin app and OBS plugin - #38

Open
YashasVM wants to merge 2 commits into
mainfrom
fix/shin-linux-pair
Open

YashasVM wants to merge 2 commits into
mainfrom
fix/shin-linux-pair

Conversation

@YashasVM

Copy link
Copy Markdown
Owner

Summary

  • ship a matched shin Android app and Linux OBS source with isolated package, module, source, URI, discovery, and port identities
  • send phone discovery directly to the selected OBS host in addition to broadcast and multicast
  • report Paired only after OBS acknowledges /reserve
  • remove the OBS dock and its frontend and Widgets dependencies, which removes the reproduced shutdown crash path
  • add an atomic Linux installer and a bounded synthetic phone probe

Verification

  • ./gradlew testDebugUnitTest assembleDebug
  • python -m pytest -q (93 passed)
  • ./build_plugin_linux.sh --install-user (5 C++ tests passed)
  • installed OBS 32.2.2 discovered and reserved a synthetic phone, received H.264 plus AAC over SRT, emitted decoded frames, released the reservation, and exited without a new core dump

The local APK is artifacts/shin-android-debug.apk. ADB had no connected Android device, so the APK was built but not sideloaded.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c2b87c4c-a9cc-464d-9ccb-bfb72b92f7dc


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YashasVM YashasVM left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yashas's code review bot: The Linux-focused pairing/crash work is well validated, and Android, Linux OBS, and Website checks pass. However, the exact PR head still fails the Windows OBS Build plugin package step; all downstream Windows contract/behavioral tests, ABI checks, package verification, installer build, and installer smoke test are consequently skipped. Because this PR changes the shared OBS plugin identity/build/package surface, I would not merge until the Windows build is restored and its downstream validation runs successfully. I found no additional high-confidence blocker in the reviewed Linux/Android changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant