Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
YashasVM
left a comment
There was a problem hiding this comment.
Yashas's code review bot: The Linux-focused pairing/crash work is well validated, and Android, Linux OBS, and Website checks pass. However, the exact PR head still fails the Windows OBS Build plugin package step; all downstream Windows contract/behavioral tests, ABI checks, package verification, installer build, and installer smoke test are consequently skipped. Because this PR changes the shared OBS plugin identity/build/package surface, I would not merge until the Windows build is restored and its downstream validation runs successfully. I found no additional high-confidence blocker in the reviewed Linux/Android changes.
Summary
shinAndroid app and Linux OBS source with isolated package, module, source, URI, discovery, and port identitiesPairedonly after OBS acknowledges/reserveVerification
./gradlew testDebugUnitTest assembleDebugpython -m pytest -q(93 passed)./build_plugin_linux.sh --install-user(5 C++ tests passed)The local APK is
artifacts/shin-android-debug.apk. ADB had no connected Android device, so the APK was built but not sideloaded.