Repository navigation
Docs: the embedded app's root is a sap.m.NavContainer after abap2UI5 1.147.0 - #30
Merged
Merged
Conversation
…1.147.0 abap2UI5/abap2UI5#2913 gives an embedded component a sap.m.NavContainer as its root instead of the full-screen sap.m.App (ownsPage keeps the sap.m.App). The README's notes on the mobile setup, on the root and on what is still the frontend's say so; two comments no longer name sap.m.App as the root. Nothing in the control changes: the root-content marker still stops the height walk of a sap.m.Shell in an app's view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GPMAtn6BycCF2mKRUHGpek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abap2UI5/abap2UI5#2913 changes the root of an embedded component.
sap.m.NavContainerinstead of the full-screensap.m.App. On the host's page it no longer sets the web-app-capable meta tag on a phone or tablet, has no theme background of its own, and sets no height of 100% on its ancestors.ownsPage: the root stays asap.m.App, as on a page of the app's own.This PR brings the docs in line with that. It should be merged after abap2UI5/abap2UI5#2913, because the text describes the abap2UI5 release after 1.147.0.
packages/embed-control/README.md:README.md: "Next steps" no longer lists busy indicator, title, favicon and the root as still the frontend's.Container.js/Container.css: two comments no longer call the rootsap.m.Appunconditionally.CHANGELOG.md: a docs line under Unreleased.Nothing in the control changes. The
data-sap-ui-root-contentmarker stays needed, because asap.m.Shellin an app's view, the hello world app's included, walks up the DOM the same way.Tests
npm test: 22 pass.npm run lint: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01GPMAtn6BycCF2mKRUHGpek
Generated by Claude Code