Repository navigation
chore: bump the pinned abap2UI5 framework commit - #270
Merged
Merged
Conversation
oblomov-dev
added a commit
that referenced
this pull request
Oct 14, 2026
The weekly bump (#270) moved A2UI5_PIN to f9dc871a, but the cell in AGENTS.md that cites the pin still read 2dd43637, so check_pins failed on main. Written by `node scripts/check-pins.mjs --fix`, the call the bump workflow is meant to make. Claude-Session: https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW Co-authored-by: Claude <noreply@anthropic.com>
oblomov-dev
added a commit
that referenced
this pull request
Oct 14, 2026
) The resolve step runs `check-pins.mjs --fix`, which rewrites the pin citation in the prose files. create-pull-request then commits only the paths in `add-paths` - A2UI5_PIN and the abaplint configs, none of the prose - so the rewrite was thrown away. The bump to f9dc871a (#270) moved the pin, left AGENTS.md citing 2dd43637, and turned check_pins red on main the moment it merged (#272 fixed the cell by hand). - bump-a2ui5.yaml: add-paths lists the nine PROSE files of check-pins.mjs, with a comment saying why they are there. - check-pins.mjs policy 7: every PROSE file that exists must be in the bump's add-paths. On the old workflow it reports all nine; on this one it passes. The two lists are one list now, held together by the gate, so a file added to PROSE later cannot be silently dropped again. - tooling.test.mjs: a case for policy 7 - the #270 shape fails, the listed file passes. npm test: 64/64. node scripts/check-pins.mjs: ok. Claude-Session: https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly re-resolve of
A2UI5_PINagainst abap2UI5 main (f9dc871a1c35c69991ede732b17c03c25daef5a3) —what node-setup, the Pages build and the e2e smoke run against.
The abaplint configs resolve main directly (unpinned), and the
nightly e2e keeps testing main tip as the canary.
The verdict at the new pin
The full backend build and the strict e2e smoke over all ports ran green at the new pin. This is a routine bump.
Run: https://github.com/abap2UI5/samples-controls/actions/runs/38399049575
Every FAIL line is a port whose live wire broke against the new
framework commit — or a harness effect, see
.claude/skills/e2e-debugging.