Repository navigation
Fix ModuleNotFoundError on Windows by making resource import optional - #162
Merged
Merged
Conversation
NONONOexe
force-pushed
the
fix/windows-resource-import
branch
from
October 16, 2026 05:33
435802e to
733567b
Compare
shima004
self-requested a review
October 16, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
import resourcefails withModuleNotFoundError,because the
resourcemodule exists only on Unix-like systems.This PR makes the import optional.
Changes
import resourceintry/except ImportErrorand setresource = Noneon failure.resource.setrlimitonly whenresourceis available.Testing
from adf_core_python.launcher import Launcherworks,and the launcher starts and waits for a server connection.