Skip to content

Fix ModuleNotFoundError on Windows by making resource import optional #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shima004 merged 2 commits into from
Oct 16, 2026
Merged

Fix ModuleNotFoundError on Windows by making resource import optional #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db62603
Make resource module import optional for Windows
NONONOexe Oct 15, 2026
733567b
Use sys.platform check for resouces import to satisfy mypy
NONONOexe Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/adf_core_python/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import argparse
import resource
import sys

if sys.platform != "win32":
import resource

from adf_core_python.core.config.config import Config
from adf_core_python.core.launcher.agent_launcher import AgentLauncher
Expand All @@ -12,13 +15,14 @@ def __init__(
self,
launcher_config_file: str,
) -> None:
try:
resource.setrlimit(resource.RLIMIT_NOFILE, (8192, 1048576))
except Exception as e:
print(
f"Failed to set resource limit: {e}. "
"This may cause issues with the number of open files."
)
if sys.platform != "win32":
try:
resource.setrlimit(resource.RLIMIT_NOFILE, (8192, 1048576))
except Exception as e:
print(
f"Failed to set resource limit: {e}. "
"This may cause issues with the number of open files."
)

self.launcher_config = Config(launcher_config_file)

Expand Down
Loading