Repository navigation
fix(publish): stop skipping a verified fix as a duplicate of its own issue - #172
Merged
Merged
Conversation
…issue When an issue is filed first and its fix is verified later, the item's own issue appears in "already on GitHub", and the publisher is told to skip anything listed there. The fix then never becomes a PR, and the stored skip hides it from later runs. A dry run has no such list, which is why it drafted the same PR correctly. Tell the publisher which issue is the item's own, and refuse a skip whose reason cites it, so the verified fix is published and closes it. Closes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: dashboardNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Contributor
|
Merged as 6d26970. |
joaquim-verges
added a commit
that referenced
this pull request
Nov 11, 2026
… main Re-applies the publish role and its tests from 'recheck false skips and report unpublished items' after merging main, so #173 lands on main without #172's duplicate commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
merge-loop Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
* fix(publish): stop skipping a verified fix as a duplicate of its own issue When an issue is filed first and its fix is verified later, the item's own issue appears in "already on GitHub", and the publisher is told to skip anything listed there. The fix then never becomes a PR, and the stored skip hides it from later runs. A dry run has no such list, which is why it drafted the same PR correctly. Tell the publisher which issue is the item's own, and refuse a skip whose reason cites it, so the verified fix is published and closes it. Closes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> * fix(publish): recheck false skips and report unpublished items A stored skip that cites a verified fix's own issue came from the false duplicate that the previous commit stops. Those items stayed hidden until someone cleared the field, so the publisher now offers them to the judge again and clears the skip when the PR opens. The skip stands when the issue is closed or an open PR will close it, so a fix shipped outside Bugpatrol does not get a second PR. A failed lookup keeps it for the next run. Every other stored skip still holds. A run that ended without publishing or skipping an item looked like a quiet pass. Those items now return as `unpublished` with the reason, including a stop on budget, a crash, or a publish tool error. The session is marked failed, `bugpatrol publish` exits 1, and a patrol records a problem for the cycle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> * chore: take main's publish role ahead of merging main (restored next commit) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> * fix(publish): restore the recheck and unpublished reporting on top of main Re-applies the publish role and its tests from 'recheck false skips and report unpublished items' after merging main, so #173 lands on main without #172's duplicate commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171
When an issue is filed first and its fix is verified later, the publisher sees the item's own issue under "already on GitHub", and its prompt says to skip anything listed there. It skips with "Duplicate of #", the fix never becomes a PR, and the stored skip hides it from later runs. A dry run has no GitHub list, which is why it drafted the same PR correctly.
Change
list_itemsandview_itemname the item's own issue and say the PR closes it.skiprefuses a PR item when the reason cites its own issue, so this no longer depends on the model following the prompt.Skipping a verified fix for another reason, such as a different PR that already covers it, stays allowed and is not reported as a failed publish. The issue suggested that as an option, and I left it out because those skips can be correct.
Verification
list_itemsshowed the verified fix, and the next action wasskipwith "Duplicate of" its own issue.publish.test.tscallsskipwith the item's own issue, expects a refusal, and expects the PR to go through. It fails on its own assertion with the guard removed.pnpm typecheck,pnpm lint,pnpm knipand thepackages/agentstests pass.🤖 Generated with Claude Code
Assisted by Nebula.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.