Repository navigation
fix(publish): recheck false skips and report unpublished items - #173
Merged
Merged
Conversation
…issue When an issue is filed first and its fix is verified later, the item's own issue appears in "already on GitHub", and the publisher is told to skip anything listed there. The fix then never becomes a PR, and the stored skip hides it from later runs. A dry run has no such list, which is why it drafted the same PR correctly. Tell the publisher which issue is the item's own, and refuse a skip whose reason cites it, so the verified fix is published and closes it. Closes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
A stored skip that cites a verified fix's own issue came from the false duplicate that the previous commit stops. Those items stayed hidden until someone cleared the field, so the publisher now offers them to the judge again and clears the skip when the PR opens. The skip stands when the issue is closed or an open PR will close it, so a fix shipped outside Bugpatrol does not get a second PR. A failed lookup keeps it for the next run. Every other stored skip still holds. A run that ended without publishing or skipping an item looked like a quiet pass. Those items now return as `unpublished` with the reason, including a stop on budget, a crash, or a publish tool error. The session is marked failed, `bugpatrol publish` exits 1, and a patrol records a problem for the cycle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: dashboardNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
joaquim-verges
changed the base branch from
fix/publish-own-issue-not-duplicate
to
main
November 10, 2026 20:06
…commit) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
… main Re-applies the publish role and its tests from 'recheck false skips and report unpublished items' after merging main, so #173 lands on main without #172's duplicate commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
Contributor
|
Merged as 06faf8d. |
joaquim-verges
added a commit
that referenced
this pull request
Nov 11, 2026
A fixed issue was resolved, often by a PR that someone opened by hand. Its GitHub issue is closed. Publish still offered a PR for the issue's own verified fix whenever that fix had no PR recorded, so a patrol would open a duplicate PR for a change that is already on main. The recheck of stored skips in #173 made this more likely, because it can revive a held-back fix. Treat a fixed issue like a dismissed one at the top of the selector, so it owes neither a PR nor an issue. The issue branch already excluded fixed issues, so that duplicate check goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
merge-loop Bot
added a commit
that referenced
this pull request
Nov 11, 2026
* fix(publish): open no PR for a fix whose issue is already fixed A fixed issue was resolved, often by a PR that someone opened by hand. Its GitHub issue is closed. Publish still offered a PR for the issue's own verified fix whenever that fix had no PR recorded, so a patrol would open a duplicate PR for a change that is already on main. The recheck of stored skips in #173 made this more likely, because it can revive a held-back fix. Treat a fixed issue like a dismissed one at the top of the selector, so it owes neither a PR nor an issue. The issue branch already excluded fixed issues, so that duplicate check goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> * Run the checks again The agent found nothing to fix in the code. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com> Co-authored-by: merge-loop[bot] <349684721+merge-loop[bot]@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #172 (base
fix/publish-own-issue-not-duplicate). Merge #172 first. This closes the two publish gaps #172 leaves open.Stored false skips
A stored skip on a verified fix that cites the item's own issue came from the false duplicate that #172 stops. These items stayed hidden until someone cleared the field.
bugpatrol issue reopen <id>remains the manual clear.Runs that end without publishing
A run that ended without publishing or skipping an item looked like a quiet pass.
unpublishedwith the reason: the publisher finished, stopped early (budget, steps, timeout), crashed, or lost a publish to a tool error.bugpatrol publishexits 1, and a patrol records a problem for the cycle.Verification
publish.test.tscover both gaps. Against the fix(publish): stop skipping a verified fix as a duplicate of its own issue #172 publisher, the revive andunpublishedcases fail on their own assertions. With the closed-issue, open-PR and failed-lookup guards removed, those three cases fail.unpublishedline and exited 1.pnpm typecheck,pnpm lint,pnpm knip,biome checkand the fullvitestsuite pass locally.🤖 Generated with Claude Code
Assisted by Nebula.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Closes #171