Skip to content

feat(amp-semantic): capture replay recording boundaries - #2152

Draft
jxiwang wants to merge 3 commits into
codex/semantic-navigationfrom
codex/semantic-recording
Draft

jxiwang wants to merge 3 commits into
codex/semantic-navigationfrom
codex/semantic-recording

Conversation

@jxiwang

@jxiwang jxiwang commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Captures compact amp-semantic/recording start, stop, and resume boundaries from Session Replay lifecycle decisions. Start/resume follows the first accepted full snapshot. Terminal stop is emitted before rrweb teardown, including customer stop and opt-out paths. The family contract also supports pause for future SDK use.

Stacked on #2151. This is the clean replacement for the recording portion of older draft #2080, using the current injected capture runtime.

Validation

  • Node 24, pnpm install --frozen-lockfile — passed
  • Semantic and Session Replay package dependency builds — passed
  • Semantic tests — 44 passed, 100% coverage
  • Session Replay Browser tests — 1,172 passed, 100% coverage
  • Semantic Playwright — 10 passed, including stop/resume transport
  • pnpm lint, pnpm lint:deps, pnpm test:examples — passed
  • Full workspace pnpm build on the parent stack stalled in unchanged Segment Session Replay Rollup. Full workspace pnpm test on the parent stack failed in unchanged analytics-react-native tests. This draft remains open pending green workspace gates.

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
packages/analytics-browser/lib/scripts/amplitude-min.js.gz 68.41 KB (0%)
packages/session-replay-browser/lib/scripts/session-replay-browser-min.js.gz 140.84 KB (+0.23% 🔺)
packages/unified/lib/scripts/amplitude-min.umd.js.gz 227.3 KB (+0.14% 🔺)
@amplitude/element-selector (gzipped esm) 3.48 KB (0%)
@amplitude/analytics-browser/lite (gzipped CDN bundle) 21.34 KB (0%)

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Session Replay Browser E2E Results

passed  158 passed
flaky  1 flaky

Details

stats  159 tests across 18 suites
duration  4 minutes, 30 seconds
commit  b723e87

Flaky tests

chromium › e2e/shadow-dom.spec.ts › captureAdoptedStyleSheets option › SDK initializes without error and captures shadow host with default (true)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant