Repository navigation
Conversation
This was referenced Oct 22, 2026
This was referenced Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire opt-in semantic capture into session-replay-browser and its analytics plugin. Start capture only after rrweb is available, emit context around full snapshots, forward navigation and recording lifecycle signals, and preserve disabled behavior and sampling boundaries across replay sessions.
This is the original lifecycle/SDK workstream. Final visibility-only transitions, user agent context, and tab/document identity are refinements in the final integration slice.
Related: SRAI-56, SRAI-64, SRAI-65.
Review stack
This is a draft review slice of the amp-semantic work. Review in order: interactions → lifecycle → page-feedback → integration. The final
codex/semantic-review-integrationtree is identical to the testedcodex/amp-semantictree after removing temporary capture diagnostics. Existing implementation workstream branches are preserved.Do not merge these slices independently yet. The final integration PR supplies the runtime entry point, shared helpers, complete schema, lockfile registration, and later refinements. Intermediate slices are not independently buildable/releasable. Before promoting the stack, arrange independently green boundaries or land the complete stack together.
Validation on the complete integration tree
Node 24.22.1 / pnpm 11.28.5:
pnpm docs:check,pnpm lint(30 projects), andpnpm lint:deps.@amplitude/amp-semanticES5/ESM build and replay SDK/plugin ES5/ESM builds.--coverage=false; this does not satisfy the coverage gate.pnpm testfails the new semantic package's inherited 100% coverage thresholds (statements 90.8%, branches 81.65%, functions 85.86%, lines 94.18%). All 148 semantic assertions pass; dependent tasks were not all run after that failure.pnpm test:examplesfails because the configuredjest.setup.examples.jsis absent from this checkout.pnpm buildemitted the replay plugin bundles but did not exit; its idle Rollup process was stopped after more than ten minutes. Full repository build is not verified.These are draft blockers, not green CI. Node 22/26 and current-main integration still need CI validation. Results above apply to the complete stack, not each intermediate branch.
Checklist