Repository navigation
#29438 feat(confluence): Show content included from other pages - #14
Open
marcreichel wants to merge 1 commit into
Open
marcreichel wants to merge 1 commit into
marcreichel wants to merge 1 commit into
Conversation
f-kuechler
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include) was dropped byOtherMacroRemover, so pages that include other pages showed up incomplete in AGP.IncludeMacroReplacerreplaces each include with the included page's storage content. It looks the page up by title in the pages passed to its constructor (usually the result offindPagesInSpace()), so it makes no extra API calls. Register it first, so the other replacers also convert the included content (images, panels, …).findIncludedPageIds()returns the IDs of the included pages.ConfluencePageContentDownloader::downloadPageContent()takes them as the new$additionalAttachmentPageIdsargument and downloads their attachments into the including page's folder. Images in the included content then resolve like the page's own.ri:space-keyis ignored, since only same-space includes are in use today.Part of artemeon/core-ng#29438