Skip to content

ci: release ilttu-plugins with release-please - #4

Merged
ajbeck merged 10 commits into
mainfrom
ajb/release-please
Nov 15, 2026
Merged

ajbeck merged 10 commits into
mainfrom
ajb/release-please

Conversation

@ajbeck

@ajbeck ajbeck commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

#3 is merged, and this now targets main.
Merge #5, the repin to ilttu-design-v0.1.1, first: the manifest here starts from its versions, ilttu 0.3.1 and ilttu-design 0.1.1.

What changed

  • release-please, as in asteroid-computing/ilttu and orca: release-please-config.json names two packages, and .release-please-manifest.json holds their last versions.
    • plugins/ilttu, release type simple, tagged ilttu-v<version>, which bumps $.version in .claude-plugin/plugin.json.
    • ilttu-design, release type go, tagged ilttu-design-v<version> as today, released as a draft with its tag made at once.
  • .github/workflows/release.yaml on push to main:
    • release-please keeps the release PR open, as the org's release App, from the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets, so its PRs run checks.
    • When ilttu-design releases, a job checks out the tag, vets, tests, builds the four binaries outside the checkout, attaches them with SHA256SUMS, and only then publishes the draft.
      The old workflow built into ilttu-design/dist/, so Go stamped every build after the first vcs.modified=true, in v0.1.0 and v0.1.1 alike; the build now fails if it leaves a file in the checkout.
    • A pin job then downloads the published SHA256SUMS, runs scripts/pin-ilttu-design, and opens fix(ilttu): run ilttu-design <version>, which the next release PR ships as a plugin release.
  • scripts/pin-ilttu-design <tag> <SHA256SUMS> rewrites the wrapper's TAG and four sums, and changes nothing unless every sum is there and every line it rewrites is found.
  • .github/workflows/ilttu-design-release.yml is gone, because a tag the App makes triggers workflows, so it would build and publish the same tag a second time.
  • check.yaml runs go vet and go test in ilttu-design/, and claude plugin validate on the marketplace and the plugin, with Claude Code pinned at 2.1.311; pr-title.yaml checks a Conventional Commit title of 72 characters or fewer.
  • AGENTS.md and SECURITY.md say how releases happen now.

Why the pins are a PR, not a commit

The wrapper's sums can only be known after the build, and they decide what runs on people's machines, so they change only through a PR someone reviews and merges.
The workflow opens it from the published release's SHA256SUMS, so nobody copies a sum by hand.

Verified

  • actionlint on all three workflows, and the config and manifest parse as JSON.
  • claude plugin validate . and claude plugin validate plugins/ilttu, also with an empty config folder and no sign-in, as CI runs them; go vet ./... and go test ./....
  • scripts/pin-ilttu-design against v0.1.0's real SHA256SUMS: it leaves the wrapper as it is, pins a new tag and sum, keeps the file executable, and refuses a short SHA256SUMS, a tag that isn't ilttu-design's, and a wrapper whose line has changed shape, each without writing.

Not verified

  • The Release workflow, which only runs on main: release-please, the build-and-publish job and the pin job.
  • What the first release PR proposes. ilttu-design-v0.1.1 is on main, so release-please should start ilttu-design there; the plugin has no tag, so I expect it to fall back to the manifest's 0.3.1 with a changelog from the start of plugins/ilttu/'s history.
  • That release-please reads component for a package: the schema doesn't list it, though src/manifest.ts reads it, and without it both packages would tag a bare v<version>.

Before it can run

  • This repository must be added to the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets' selected repositories; the App is already installed on all of the org's repositories.
  • Optional, as ilttu has it: turn on immutable releases, so a published release's tag and binaries can never change.

release-please keeps one release PR for the ilttu plugin (ilttu-v*) and
ilttu-design (ilttu-design-v*). When ilttu-design releases, the Release
workflow builds it from the tag, publishes the draft, and opens a PR that
pins it in the wrapper with scripts/pin-ilttu-design. The tag-push
workflow goes, so one path releases. Check and PR title workflows run the
AGENTS.md checks on every PR.
Base automatically changed from ajb/preview-server to main November 15, 2026 16:21
…ugins into ajb/release-please

# Conflicts:
#	AGENTS.md
#	SECURITY.md
A binary left in ilttu-design/dist made Go stamp every later build of a
release vcs.modified=true, as in v0.1.0 and v0.1.1. The build now writes
to RUNNER_TEMP and fails if it leaves a file in the checkout. The
manifest starts from ilttu-design 0.1.1, now tagged on main, and the
plugin's 0.3.1 from the repin PR.

@ajbeck ajbeck left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 0251a4b: approve, once this repository is added to the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets' selected repositories. Neither lists it today, so the first Release run would fail when it mints the App token.

Medium (repository setting): main has no branch protection and no rulesets, so SECURITY.md's "pins change only through a reviewed PR" is not enforced; anyone with write access, or the App token, could push to main directly. Add a ruleset that requires a PR on main and lets release-please's tags through.

Low: Check ran at 16:28 and #5 merged at 16:29, so the green run tested a merge ref without #5. The merge is CLEAN, and the v0.1.1 pins survive.

Open for AJ:

  • Accept the AGENTS.md rule edits on releases? Recommend yes; they follow ilttu's walle.md.
  • Set bootstrap-sha (see the comment on the config)? Recommend yes.
  • Turn on immutable releases? Recommend yes, as in ilttu.
  • Require PRs on main? Recommend yes.

Verified: every action is pinned by SHA and each SHA matches its tag. Each job's permissions are narrow, and there is no pull_request_target. The secrets are used only to mint App tokens, in the release-please and pin jobs. The build runs from the tag, outside the checkout, and publishes only after the upload. pin-ilttu-design refuses partial input. release-please reads component, draft and force-tag-creation per package. The manifest matches main. No workflow triggers on a tag, so nothing builds a tag twice.

Not verified: the Release workflow has never run; the App's installation here; the first release PR's contents. I made no worktree and no deliberate breaks; the review was read-only.

Comment thread release-please-config.json Resolved
Comment thread .github/workflows/release.yaml Resolved
Comment thread .github/workflows/release.yaml Resolved
Comment thread .github/workflows/release.yaml Resolved
Comment thread .github/workflows/release.yaml Resolved
Start release-please's history at #5's merge, so the plugin's first
release PR doesn't repeat what 0.3.1 shipped. Fail the build step when
git status fails, download SHA256SUMS in a step of its own so the pin
script's step has no token in its env, and let a rerun of the pin job
succeed once the pin is on main.
@ajbeck

ajbeck commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Ready for review: #4, head a2c3f10eee10f31252c920a509db56db640bcf9b.

What changed since 0251a4b

  • main merged in, with fix(ilttu): run ilttu-design v0.1.1, built from main #5: the wrapper pins v0.1.1, the plugin is 0.3.1, and the merge was clean.
  • bootstrap-sha is fix(ilttu): run ilttu-design v0.1.1, built from main #5's merge, ffd0703, so the plugin's first release PR starts after what 0.3.1 shipped.
  • The build comment no longer tells history.
  • The build step's check that it left no file now stops the step if git status itself fails, and prints what was left.
  • SHA256SUMS downloads in a step of its own, so the step that runs scripts/pin-ilttu-design has no token in its env; a comment says why the token checkout keeps for the push is acceptable.
  • A rerun of the pin job succeeds and does nothing once the pin is on main.

Each review thread has a reply.

Verified

  • actionlint on the three workflows, the config parses as JSON, claude plugin validate on the marketplace and the plugin, and go vet and go test in ilttu-design/.

Not verified

  • The Release workflow, which has never run, and so the first release PR's contents.

Choices put to AJ

  • Accept the AGENTS.md rule edits on releases.
  • Keep bootstrap-sha (applied, one line to drop).
  • Turn on immutable releases.
  • Add a ruleset that requires a PR on main.

Before merging, AJ adds this repository to the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets' selected repositories.

@ajbeck ajbeck left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of a2c3f10: fixes accepted, waiting on AJ

All five findings are fixed as suggested:

  • bootstrap-sha is ffd0703.
  • The comment at :82 no longer tells history.
  • The git status check fails when git status itself fails.
  • A rerun after the pin has merged does nothing.
  • SHA256SUMS downloads in its own step, so the pin script runs with no token in its env.

Open for AJ, before merge:

  • Add this repository to the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets' selected repositories.
  • The four choices, which the session put to AJ: the AGENTS.md release rules, bootstrap-sha, immutable releases, and a ruleset requiring PRs on main.

Verified: I read the fix diff from 0251a4b to a2c3f10.

Not verified:

  • The Release workflow, which has never run.
  • The Check run on this head.

@ajbeck

ajbeck commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

AJ's answers to the four choices, in this session: "Yes, all four" (2026-11-15).

  • The AGENTS.md rule edits on releases: accepted, as in this PR.
  • bootstrap-sha ffd0703: kept, as in this PR.
  • Immutable releases: turned on for this repository.
  • A ruleset requiring PRs on main: added as ruleset main (27320386), copied from ilttu's. It blocks deletion and force pushes, requires a squash-merged PR with every review thread resolved, and requires the checks ilttu-design, Plugin manifests and Conventional Commit title. It has no bypass; release-please and the pin job only push their own branches and tags.

Still AJ's before merge: add this repository to the RELEASE_PLEASE_CLIENT_ID and RELEASE_PLEASE_PRIVATE_KEY org secrets' selected repositories.
This PR now shows BLOCKED, most likely by its five answered but unresolved review threads.

@ajbeck
ajbeck merged commit 488023a into main Nov 15, 2026
3 checks passed
@ajbeck
ajbeck deleted the ajb/release-please branch November 15, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant